Fix write global seqno #1563
Merged
Fix write global seqno #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o false by default. apache#1560 apache#1560 Add rocksdb_write_global_seqno, and set its default value to false.
…efault. apache#1562 apache#1562 Add rocksdb_write_global_seqno, and set its default value to false.
hycdong
approved these changes
Jul 10, 2023
hycdong
added
the
type/config-change
|
This pull request adds a new configuration, please add it into your pr description like the old one: XiaoMi/rdsn#851 |
empiredan
approved these changes
Jul 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1562
Add this option to turn off rocksdb modifying
rocksdb.external_sst_file.global_seqnofield of external sst file during ingest process. This is used to address a coredump
caused by incorrect field value in RocksDB. This pull request fixs the bug above.
Rocksdb 6.6.4 no longer recommends using this field.
New configuration is added:
[pegasus.server] + rocksdb_write_global_seqno = false