Feature:Online Query and Dynamic Modification of Table-level RocksDB Options #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… RocksDB Options (apache#1488) apache#1488 Complete the dynamic setting function of num_levels and write_buffer_size option.I use rocksdb.write_buffer_size as a dynamically modifiable parameter and rocksdb.num_levels as a non-dynamically modifiable parameter to test my idea. Pegasus shell case: create lpf -e rocksdb.num_levels=12,rocksdb.write_buffer_size=100 create lpf -e rocksdb.num_levels=5,rocksdb.write_buffer_size=100 create lpf -e rocksdb.num_levels=5,rocksdb.write_buffer_size=33554432 set_app_envs rocksdb.write_buffer_size 67108864 set_app_envs rocksdb.num_levels 4 get_app_envs
…Options (apache#1488) apache#1488 Currently, I only perform strict validation of app envs during the create_app command process. However, in the set_app_envs command, there is no validation for invalid envs, and they are simply not processed. - Manual test (add detailed scripts or steps below) Pegasus shell case: create lpf -e rocksdb.num_levels=12,rocksdb.write_buffer_size=100 create lpf -e rocksdb.num_levels=5,rocksdb.write_buffer_size=100 create lpf -e rocksdb.num_levels=5,rocksdb.write_buffer_size=33554432 set_app_envs rocksdb.write_buffer_size 67108864 set_app_envs rocksdb.write_buffer_size 100 get_app_envs
hycdong
reviewed
Jun 13, 2023
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
hycdong
previously approved these changes
Jun 14, 2023
empiredan
reviewed
Jun 14, 2023
…d adjusted my code.
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
empiredan
reviewed
Jun 19, 2023
ruojieranyishen
force-pushed
the
master
branch
4 times, most recently
from
ea1ed49 to
2ac14c2
Compare
…ode. Mainly the following aspects: 1. Improve the unit test to ensure that the new option can also be added correctly. 2. Add getter and setter methods for option.
empiredan
reviewed
Jul 11, 2023
ruojieranyishen
force-pushed
the
master
branch
2 times, most recently
from
5c90ad5 to
5d94ede
Compare
empiredan
reviewed
Jul 28, 2023
ruojieranyishen
force-pushed
the
master
branch
3 times, most recently
from
f494be6 to
8b32c78
Compare
ruojieranyishen
force-pushed
the
master
branch
2 times, most recently
from
6625e4a to
c31bd00
Compare
empiredan
approved these changes
Aug 10, 2023
acelyc111
reviewed
Aug 10, 2023
| ROCKSDB_NUM_LEVELS, | ||
| }; | ||
|
|
||
| const std::unordered_map<std::string, cf_opts_setter> cf_opts_setters = { |
There was a problem hiding this comment.
Have you checked the functions provided by rocksdb here? I guess it's not needed to check the options ourselves.
There was a problem hiding this comment.
Thanks, I didn't see this function before. Can i solve this problem in next PR？
acelyc111
approved these changes
Aug 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Feature:Online Query and Dynamic Modification of Table-level RocksDB Options (#1488)
#1488
Complete the dynamic setting function of num_levels and write_buffer_size option.I use rocksdb.write_buffer_size as a dynamically modifiable parameter and rocksdb.num_levels as a non-dynamically modifiable parameter to test my idea.
What is changed and how does it work?
config.inifile.createorset_app_envscommand.createcommand.app env), only the RocksDB options set through thecreateorset_app_envscommand will be available for online querying.[pegasus.server]section of theconfig.inifile.Tests
Unit test is add in meta_app_envs_test.update_app_envs_test
Pegasus shell case:
create lpf -e rocksdb.num_levels=12,rocksdb.write_buffer_size=100
create lpf -e rocksdb.num_levels=5,rocksdb.write_buffer_size=100
create lpf -e rocksdb.num_levels=5,rocksdb.write_buffer_size=33554432
set_app_envs rocksdb.write_buffer_size 67108864
set_app_envs rocksdb.num_levels 4
get_app_envs