Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Ranger): Compatible with the old ACL and the new ACL #1379

Merged
merged 2 commits into from
Mar 9, 2023
Merged

feat(Ranger): Compatible with the old ACL and the new ACL #1379

merged 2 commits into from
Mar 9, 2023

Conversation

WHBANG
Copy link
Contributor

@WHBANG WHBANG commented Mar 1, 2023 •
edited by empiredan
Loading

What problem does this PR solve?

#1054

This patch is compatible with old and new acl.

  • Modify some method names and parameter names to make them more accurate.
  • Defines the configuration parameters that the new ACL needs to use.
  • Two new 'allowed()' methods are provided for meta_server and replica_server.
  • Some incompatible methods will be removed, (allowed&pre_check)commented.

New configuration is added:

[security]
+ enable_ranger_acl = false

@github-actions github-actions bot added the cpp label Mar 1, 2023
acelyc111
acelyc111 reviewed Mar 2, 2023
View reviewed changes
src/runtime/security/access_controller.cpp Outdated Show resolved Hide resolved
src/runtime/security/access_controller.cpp Outdated Show resolved Hide resolved
src/runtime/security/access_controller.cpp Show resolved Hide resolved
src/runtime/security/access_controller.cpp Show resolved Hide resolved
src/runtime/security/access_controller.h Outdated Show resolved Hide resolved
@WHBANG WHBANG changed the title feat(security): Use Apache Ranger for access control(4/n) feat(security): compatible with old and new acl(4/n) Mar 3, 2023
@WHBANG WHBANG changed the title feat(security): compatible with old and new acl(4/n) feat(security): compatible with old and new ACL(4/n) Mar 3, 2023
@WHBANG WHBANG force-pushed the ranger_access_contoller branch from 3d5f5bf to 46b9450 Compare March 3, 2023 12:23
@WHBANG WHBANG changed the title feat(security): compatible with old and new ACL(4/n) feat(security): Compatible with the old ACL and the new ACL(4/n) Mar 3, 2023
@acelyc111 acelyc111 changed the title feat(security): Compatible with the old ACL and the new ACL(4/n) feat(Ranger): Compatible with the old ACL and the new ACL Mar 6, 2023
@empiredan empiredan merged commit 84ce5fb into apache:master Mar 9, 2023
@empiredan empiredan mentioned this pull request Aug 21, 2023
Closed
@empiredan empiredan added the type/config-change Added or modified configuration that should be noted on release note of new version. label Nov 29, 2023
GehaFearless pushed a commit to GehaFearless/incubator-pegasus that referenced this pull request Feb 28, 2024
@acelyc111
[SKV-627] feat(Ranger): Compatible with the old ACL and the new ACL (a…
53e5a22 
…pache#1379)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acelyc111 acelyc111 acelyc111 approved these changes

@empiredan empiredan empiredan approved these changes

Assignees
No one assigned
Labels
cpp type/config-change Added or modified configuration that should be noted on release note of new version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WHBANG @empiredan @acelyc111