Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose parameter success_if_exist for interface create_app #1148

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

GehaFearless
Copy link
Contributor

What problem does this PR solve?

#1147

acelyc111
acelyc111 previously approved these changes Dec 22, 2022
Copy link
Member

@acelyc111 acelyc111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! LGTM

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@9a6702a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
go-client/admin/client.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1148   +/-   ##
=========================================
  Coverage          ?   53.30%           
=========================================
  Files             ?       27           
  Lines             ?     2527           
  Branches          ?        0           
=========================================
  Hits              ?     1347           
  Misses            ?     1134           
  Partials          ?       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelyc111 acelyc111 merged commit cb99a6b into apache:master Dec 22, 2022
@empiredan empiredan mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants