-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce data sink to collect snapshot from each metric periodically #1117
Open
empiredan
wants to merge
24
commits into
apache:master
Choose a base branch
from
empiredan:metric-data-sink
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+771
−110
Open
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
98efadf
feat: take snapshots from metrics and export to data sink
empiredan 73c1796
feat: take snapshots from metrics and export to data sink
empiredan 0a9e3ac
feat: take snapshots from metrics and export to data sink
empiredan 4d1e33b
feat: take snapshots from metrics and export to data sink
empiredan a8ac596
feat: take snapshots from metrics and export to data sink
empiredan e1c6bfd
feat: take snapshots from metrics and export to data sink
empiredan 017f945
feat: take snapshots from metrics and export to data sink
empiredan 37fc291
feat: take snapshots from metrics and export to data sink
empiredan c9629f0
feat: take snapshots from metrics and export to data sink
empiredan e04d72e
feat: take snapshots from metrics and export to data sink
empiredan 1b9f4af
feat: take snapshots from metrics and export to data sink
empiredan 4768e58
feat: take snapshots from metrics and export to data sink
empiredan 1220915
feat: take snapshots from metrics and export to data sink
empiredan 83200e1
feat: take snapshots from metrics and export to data sink
empiredan 85f3f26
feat: take snapshots from metrics and export to data sink
empiredan c92ef2d
feat: take snapshots from metrics and export to data sink
empiredan 3c1f503
feat: take snapshots from metrics and export to data sink
empiredan 5be088c
feat: take snapshots from metrics and export to data sink
empiredan 3b3d9dc
feat: take snapshots from metrics and export to data sink
empiredan f108b67
feat: take snapshots from metrics and export to data sink
empiredan 7e6393a
feat: introduce data sink to collect snapshot from each metric period…
empiredan 5881d9b
feat: introduce data sink to collect snapshot from each metric period…
empiredan 36fac25
feat: introduce data sink to collect snapshot from each metric period…
empiredan eb116eb
feat: introduce data sink to collect snapshot from each metric period…
empiredan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: take snapshots from metrics and export to data sink
commit c9629f06d0bacd0462804621348d665e31e47e1b
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why change to use std:map?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the attributes of an entity will be used as the labels of the metric. The labels will later be passed to
metric_snapshot
, thus each metric snapshot may has multiple labels. To maintain each snapshot in a map, data sink may choose to encode the labels a snapshot has, as whatmetric_snapshot::encode_attributes
has done. In comparison withstd::unordered_map
, it is easier forstd::map
to be encoded since it's ordered.