-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rocksdb options not changed even if update in Pegasus config file #1108
Merged
acelyc111
merged 23 commits into
apache:master
from
WHBANG:dev/rocksdb_options_not_change
Aug 25, 2022
Merged
fix: rocksdb options not changed even if update in Pegasus config file #1108
acelyc111
merged 23 commits into
apache:master
from
WHBANG:dev/rocksdb_options_not_change
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Aug 10, 2022
WHBANG
force-pushed
the
dev/rocksdb_options_not_change
branch
from
August 11, 2022 13:32
6f574c1
to
b74d120
Compare
acelyc111
reviewed
Aug 12, 2022
WHBANG
force-pushed
the
dev/rocksdb_options_not_change
branch
4 times, most recently
from
August 16, 2022 13:36
2aa9f41
to
539dab2
Compare
WHBANG
force-pushed
the
dev/rocksdb_options_not_change
branch
from
August 16, 2022 17:16
539dab2
to
497c8a9
Compare
WHBANG
force-pushed
the
dev/rocksdb_options_not_change
branch
from
August 17, 2022 03:18
497c8a9
to
ad93831
Compare
acelyc111
reviewed
Aug 17, 2022
acelyc111
reviewed
Aug 17, 2022
empiredan
reviewed
Aug 18, 2022
empiredan
previously approved these changes
Aug 19, 2022
acelyc111
reviewed
Aug 19, 2022
Co-authored-by: Yingchun Lai <[email protected]>
acelyc111
reviewed
Aug 23, 2022
acelyc111
reviewed
Aug 23, 2022
acelyc111
previously approved these changes
Aug 24, 2022
empiredan
reviewed
Aug 24, 2022
empiredan
approved these changes
Aug 25, 2022
acelyc111
approved these changes
Aug 25, 2022
ZhongChaoqiang
pushed a commit
to ZhongChaoqiang/incubator-pegasus
that referenced
this pull request
Nov 28, 2022
…erver into .app-info file for each replica (apache#1108)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#1025
What is changed and how does it work?
The specific reason is that if you open an existing rocksdb, the usage scenario will be set to normal first, and then set to the corresponding mode according to the actual usage scenario. This process will change the relevant options, causing rocksdb to execute flush and compact, so in order to avoid this situation (#587), rocksdb::LoadLatestOptions is called, and these parameters are initialized with the last value, so the last thing you see is that if the configuration file is modified, and without changing the usage scenario mode, these modified configurations will not take effect after restart.
Options involved:
Solution:
Tests
Unit test
Manual test (add detailed scripts or steps below)