feat(backup): 2. update and refactor meta backup engine class #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Aug 9, 2022
acelyc111
reviewed
Aug 9, 2022
The action can add more detail info, for example, we update |
It depends on the source code are well organized, but currently they are not, we can do that after several refactors. |
|
the failed test case |
foreverneverer
approved these changes
Aug 10, 2022
ZhongChaoqiang
pushed a commit
to ZhongChaoqiang/incubator-pegasus
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1081
As the issue shows, meta_backup_engine will intertact with replica server and contorl backup lifecycle and status switch. This pr is the first part about it, including:
init_backupandstartfunctionsbackup_statusandbackup_itemstructuresmeta_backup_engine.hbackup_engineintometa_backup_enginemeta_backup_engine.hincluding public/private, function definition order etc.