Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Build on M1 MacOS #1094

Merged
merged 3 commits into from
Aug 11, 2022
Merged

feat: Support Build on M1 MacOS #1094

merged 3 commits into from
Aug 11, 2022

Conversation

GehaFearless
Copy link
Contributor

@GehaFearless GehaFearless commented Aug 1, 2022 •
edited
Loading

issue: #1093

patch relate by jemalloc/jemalloc#1997

@GehaFearless GehaFearless changed the title Support Build on M1 MacOS feat: Support Build on M1 MacOS Aug 1, 2022
@neverchanje
Copy link
Contributor

neverchanje commented Aug 2, 2022 •
edited
Loading 

CMake Error at /opt/homebrew/Cellar/cmake/3.23.3/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY
  OPENSSL_INCLUDE_DIR)

Did you encounter this problem? Testing your branch on my local mac m1.

@GehaFearless
Copy link
Contributor Author 

CMake Error at /opt/homebrew/Cellar/cmake/3.23.3/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR (missing: OPENSSL_CRYPTO_LIBRARY
  OPENSSL_INCLUDE_DIR)

Did you encounter this problem? Testing your branch on my local mac m1.

You should export OPENSSL_ROOT_DIR="/usr/local/opt/openssl".
Also you need brew install snappy brew install lz4 brew install zstd brew install [email protected]

@acelyc111
Copy link
Member

Did you encounter this problem? Testing your branch on my local mac m1.

You should export OPENSSL_ROOT_DIR="/usr/local/opt/openssl". Also you need brew install snappy brew install lz4 brew install zstd brew install [email protected]

Yes, reference to https://github.com/apache/incubator-pegasus/blob/master/.github/workflows/lint_and_test_cpp.yaml#L298

acelyc111
acelyc111 reviewed Aug 2, 2022
View reviewed changes
.licenserc.yaml Outdated Show resolved Hide resolved
@acelyc111
Copy link
Member

could you check why jemalloc hasn't been rebuilt?
https://github.com/apache/incubator-pegasus/runs/7624482151?check_suite_focus=true#step:5:31

@GehaFearless
Copy link
Contributor Author

Details

https://github.com/apache/incubator-pegasus/runs/7644893971?check_suite_focus=true

neverchanje
neverchanje approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried yet but if it won't impact the linux build then we can merge it now.

@acelyc111 acelyc111 merged commit fa88d6a into apache:master Aug 11, 2022
@empiredan empiredan mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acelyc111 acelyc111 acelyc111 approved these changes

@neverchanje neverchanje neverchanje approved these changes

Assignees
No one assigned
Labels
build thirdparty
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GehaFearless @neverchanje @acelyc111