Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert zk c client to 3.4.10 for compatibility #1088

Merged
merged 4 commits into from
Aug 12, 2022

Conversation

foreverneverer
Copy link
Contributor

@foreverneverer foreverneverer commented Aug 1, 2022

What problem does this PR solve?

Related issue: #1092

What is changed and how does it work?

This pr revert zk c client to 3.4.10, this need merge into Pegasus 2.4: #1032

Checklist

Tests
  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
Related changes
  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Copy link
Member

@acelyc111 acelyc111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s disccus clearly before merging, thanks!

@foreverneverer
Copy link
Contributor Author

Let’s disccus clearly before merging, thanks!

OK, I hope it can be determined as soon as possible, because the release of 2.4 has been postponed for a long time. If it can't be solved, I hope this problem can be reconsidered after 2.4

@acelyc111
Copy link
Member

acelyc111 commented Aug 2, 2022

Let’s disccus clearly before merging, thanks!

OK, I hope it can be determined as soon as possible, because the release of 2.4 has been postponed for a long time. If it can't be solved, I hope this problem can be reconsidered after 2.4

How about release 2.4 without this patch, and you can release an internal release or a other type of spcial release with this patch. In SensorsData we have tested with zk client 3.7.0 with zk server (version 3.4.7) kerberos enabled and disabled, all works well as expected. And you guys also tested that in some product envs, I guess there may be some DNS issue in you mentioned "tjwq-test" env :)

@acelyc111 acelyc111 changed the base branch from master to v2.4 August 12, 2022 07:26
@acelyc111
Copy link
Member

LGTM to merge it to branch 2.4.0

@foreverneverer foreverneverer merged commit 744460a into apache:v2.4 Aug 12, 2022
ZhongChaoqiang pushed a commit to ZhongChaoqiang/incubator-pegasus that referenced this pull request Nov 28, 2022
GehaFearless pushed a commit to GehaFearless/incubator-pegasus that referenced this pull request Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants