Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: The conf server_list of meta_server support use fqdn:port #1061

Merged
merged 2 commits into from
Jul 21, 2022
Merged

feat: The conf server_list of meta_server support use fqdn:port #1061

merged 2 commits into from
Jul 21, 2022

Conversation

WHBANG
Copy link
Contributor

@WHBANG WHBANG commented Jul 18, 2022 •
edited
Loading

What problem does this PR solve?

#1058

What is changed and how does it work?

meta server conf change:

[meta_server]
    server_list = hybrid01.com.deployoctopus-xxxx-debugbox:8170
Tests
  • Manual test (add detailed scripts or steps below)
  1. change the configuration server_list of the meta server to fqdn:port
  2. The service can be started
  3. The related pegasus shell is running normally

@WHBANG WHBANG changed the title feature: The conf server_list of meta_server support use fqdn:port feat:vThe conf server_list of meta_server support use fqdn:port Jul 18, 2022
@WHBANG WHBANG changed the title feat:vThe conf server_list of meta_server support use fqdn:port feat: The conf server_list of meta_server support use fqdn:port Jul 18, 2022
acelyc111
acelyc111 reviewed Jul 20, 2022
View reviewed changes
src/rdsn/src/common/replication_common.cpp Outdated Show resolved Hide resolved
src/rdsn/src/common/replication_common.cpp Outdated Show resolved Hide resolved
src/rdsn/src/common/replication_common.cpp Outdated Show resolved Hide resolved
src/rdsn/src/common/replication_common.cpp Outdated Show resolved Hide resolved
src/rdsn/src/common/replication_common.cpp Outdated Show resolved Hide resolved
@foreverneverer foreverneverer merged commit a3d43b7 into apache:master Jul 21, 2022
@foreverneverer foreverneverer mentioned this pull request Aug 4, 2022
Closed
ZhongChaoqiang pushed a commit to ZhongChaoqiang/incubator-pegasus that referenced this pull request Nov 28, 2022
@empiredan @acelyc111
feat(update_replication_factor#1): support to get the replication fac…
5010f49 
…tor of each table (apache#1061)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foreverneverer foreverneverer foreverneverer approved these changes

@acelyc111 acelyc111 acelyc111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WHBANG @acelyc111 @foreverneverer