feat(thirdparty): use official rocksdb #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
commented
Jul 12, 2022
levy5307
previously approved these changes
Jul 14, 2022
foreverneverer
requested changes
Jul 14, 2022
Better to convert it to draft :) |
acelyc111
force-pushed
the
use_official_rocksdb
branch
from
ee9db91 to
a885555
Compare
acelyc111
force-pushed
the
use_official_rocksdb
branch
2 times, most recently
from
2a6dee8 to
779906c
Compare
@foreverneverer Since we have created an separete branch v2.4 for releasing 2.4.0, so could we continue this work? |
acelyc111
force-pushed
the
use_official_rocksdb
branch
from
779906c to
78d7a45
Compare
acelyc111
force-pushed
the
use_official_rocksdb
branch
from
78d7a45 to
b0d7c7c
Compare
foreverneverer
approved these changes
Nov 8, 2022
acelyc111
added
the
type/incompatible
empiredan
approved these changes
Nov 8, 2022
ZhongChaoqiang
pushed a commit
to ZhongChaoqiang/incubator-pegasus
that referenced
this pull request
Nov 28, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1047
For some historical reasons, we use the Xiaomi modified rocksdb library. Since Pegasus 2.1.0, we have removed all modifications on rocksdb, only left some code to keep compatiable [1], now we are planning to switch to the official version.
It's expect that
thirdparty/rocksdb_fix_atomic_flush_0879c240.patchmust be corresponding to this patch [2].ATTENTION: There is a limit that the server must be upgraded from 2.1, 2.2, 2.3 or 2.4, to ensure that there is no Pegasus introduced tags which the official rocksdb doesn't recognize left in MANIFEST file.