Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support new comparator because of design #1037

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: support new comparator because of design #1037

wants to merge 1 commit into from

Conversation

shenxingwuying
Copy link
Contributor

@shenxingwuying shenxingwuying commented Jul 7, 2022 •
edited by acelyc111
Loading

add a pegasus comparator to support a normal users' sort.

Using new pegasus comparator will solve many scan timeout problems.
Pegasus can be compatible apps(tables) using the old comparator.
pegasus comparator will be the new table's default comparator.

more details at: #729

What problem does this PR solve?

What is changed and how does it work?

Checklist

Tests
  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
Code changes
  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change
Side effects
  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility
Related changes
  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@shenxingwuying shenxingwuying force-pushed the dev/pegasus_comparator_after_unified_rdsn branch 3 times, most recently from c594564 to b3949e3 Compare July 13, 2022 15:50
@shenxingwuying shenxingwuying force-pushed the dev/pegasus_comparator_after_unified_rdsn branch 3 times, most recently from 2da033a to 5b759f4 Compare July 16, 2022 06:43
@shenxingwuying shenxingwuying changed the title WIP feat: support new comparator because of design feat: support new comparator because of design Jul 16, 2022
feat: support new comparator because of design
65ca639 
WIP.
add a pegasus comparator to support a normal users' sort.

Using new pegasus comparator will solve many scan timeout problems.
Pegasus can be compatible apps(tables) using the old comparator.
pegasus comparator will be the new table's default comparator.

more details at: apache#729
@shenxingwuying shenxingwuying force-pushed the dev/pegasus_comparator_after_unified_rdsn branch from 5b759f4 to 65ca639 Compare July 16, 2022 06:45
ZhongChaoqiang pushed a commit to ZhongChaoqiang/incubator-pegasus that referenced this pull request Nov 28, 2022
@empiredan
fix: remove min_live_node_count_for_unfreeze from meta_options to ens…
dc8d6e0 
…ure it can be correctly updated dynamically (apache#1037)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cpp thrift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shenxingwuying