-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(update_replication_factor#12): update the mutation_2pc_min_replica_count base the max count of table #1035
Merged
acelyc111
merged 15 commits into
apache:master
from
foreverneverer:fix-refactor-min-count
Jul 12, 2022
Merged
fix(update_replication_factor#12): update the mutation_2pc_min_replica_count base the max count of table #1035
acelyc111
merged 15 commits into
apache:master
from
foreverneverer:fix-refactor-min-count
Jul 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foreverneverer
changed the title
fix
fix: update the mutation_2pc_min_replica_count base the max count of table
Jul 7, 2022
foreverneverer
changed the title
fix: update the mutation_2pc_min_replica_count base the max count of table
fix(update_replication_factor#12): update the mutation_2pc_min_replica_count base the max count of table
Jul 8, 2022
acelyc111
reviewed
Jul 8, 2022
empiredan
reviewed
Jul 8, 2022
empiredan
reviewed
Jul 11, 2022
empiredan
reviewed
Jul 11, 2022
empiredan
reviewed
Jul 12, 2022
empiredan
previously approved these changes
Jul 12, 2022
acelyc111
reviewed
Jul 12, 2022
acelyc111
approved these changes
Jul 12, 2022
empiredan
approved these changes
Jul 12, 2022
Closed
ZhongChaoqiang
pushed a commit
to ZhongChaoqiang/incubator-pegasus
that referenced
this pull request
Nov 28, 2022
… ingestion_context class (apache#1035)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref-Issue
#865
What problem does this PR solve?
#865 support different replica factor, but
mutation_2pc_min_replica_count
still keep2
, if one table update the factor to2
, when one replica is down(for example, offline node case), the table would keepwrite reject
status.So
mutation_2pc_min_replica_count
should be updated base the table factor, this pr should set itreplica_max_count /2 + 1
, but consider that sometimes user need set thereplica_max_count > 3
, I think the configmutation_2pc_min_replica_count
is still valid:mutation_2pc_min_replica_count > 0
, the final2pc_min_replica_count = mutation_2pc_min_replica_count
2pc_min_replica_count = app_max_replica_count <= 2 ? 1 : app_max_replica_count / 2 + 1
which can be make sure the table is alive though more node crushConfig-Change
if you want use value of
config.ini
, you don't need update it, otherwise:What is changed and how does it work?
Checklist
Tests
Related changes