Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(thirdparty): add thirdparty for centos6 build env #1017

Merged
merged 7 commits into from
Jul 6, 2022
Merged

build(thirdparty): add thirdparty for centos6 build env #1017

merged 7 commits into from
Jul 6, 2022

Conversation

foreverneverer
Copy link
Contributor

@foreverneverer foreverneverer commented Jun 24, 2022 •
edited
Loading

Ref-Issue

#903

XiaoMi/rdsn#979

Change

XiaoMi/rdsn#979 remove krb5 and cyrus-sasl, but it's necessary for CentOS6 when compile zookeeper.

In pack_server.sh, it also need be update

Note

  • if you find typedef 'zoo_sasl_client_t' re-defination , that indicates that it conflicts with the system library. Be sure to uninstall the system cyrus-sasl
  • if you find undefined reference to 'zookeeper_init_sasl', it because that zookeeper compile before cyrus-sasl, please remove all zookeeper compile result and re-run build

@foreverneverer foreverneverer changed the title fix: add thirdparty for centos6 build env build(thirdparty): add thirdparty for centos6 build env Jun 24, 2022
hycdong
hycdong previously approved these changes Jun 24, 2022
View reviewed changes
acelyc111
acelyc111 reviewed Jun 24, 2022
View reviewed changes
Copy link
Member

@acelyc111 acelyc111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rdsn/thirdparty/CMakeLists.txt Show resolved Hide resolved
foreverneverer pushed a commit to foreverneverer/pegasus that referenced this pull request Jun 27, 2022
@acelyc111
fix: use fsync() to prevent .app-info/.init-info lost risk on XFS aft…
ac8f8de 
…er power outage (apache#1017)
hycdong
hycdong previously approved these changes Jun 27, 2022
View reviewed changes
@foreverneverer foreverneverer reopened this Jul 1, 2022
acelyc111
acelyc111 requested changes Jul 1, 2022
View reviewed changes
Copy link
Member

@acelyc111 acelyc111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@foreverneverer foreverneverer reopened this Jul 5, 2022
@foreverneverer foreverneverer merged commit 862c824 into apache:master Jul 6, 2022
acelyc111 added a commit to acelyc111/pegasus that referenced this pull request Sep 7, 2023
@acelyc111
Revert "build(thirdparty): add thirdparty for centos6 build env (apac…
8aff46e 
…he#1017)"

This reverts commit 862c824.
acelyc111 added a commit that referenced this pull request Sep 10, 2023
@acelyc111
Revert "build(thirdparty): add thirdparty for centos6 build env (#1017)…
26b99e1 
…" (#1600)

* Revert "build(thirdparty): add thirdparty for centos6 build env  (#1017)"

This reverts commit 862c824.

* push master images

* run ASAN in Ubuntu 2204

* revert

* 1804

* 1804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hycdong hycdong hycdong approved these changes

@acelyc111 acelyc111 acelyc111 approved these changes

Assignees
No one assigned
Labels
thirdparty
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foreverneverer @acelyc111 @hycdong