Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one doc of admin-cli is misleading #986

Closed
felixdae opened this issue May 30, 2022 · 0 comments
Closed

one doc of admin-cli is misleading #986

felixdae opened this issue May 30, 2022 · 0 comments

Comments

@felixdae
Copy link
Contributor

felixdae commented May 30, 2022

Pegasus-AdminCli-1.2.0 » help create

Create a Pegasus table.

Please pay attention to the partition number. It usually depends on the table's on-disk storage size.
To achieve an predictable performance, you should keep the average partition size within a acceptable
range.

Usage:
  create <table> [-p|--partitions <NUM>] [-r|--replica <NUM>]

Args:
  table  string    the table name

Flags:
  -h, --help              display help
  -p, --partitions int    the number of partitions (default: 4)
  -r, --replica    int    the number of replicas (default: 3)

by following the usage, you just can't create a table successfully

Pegasus-AdminCli-1.2.0 » create test_create -p 4 -r 3
error: invalid usage of command 'create' (unconsumed input '-p 4 -r 3'), try 'help'

as a matter of fact, you can create tables as below, so i think the usage doc is wrong. it should be create [-p|--partitions <NUM>] [-r|--replica <NUM>] <table>

Pegasus-AdminCli-1.2.0 » create -p 4 -r 3 test_create1
Creating table "test_create1" (AppID: 3)
Available partitions:
4 / 4 [-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00% 5 p/s 1s
Done!
Pegasus-AdminCli-1.2.0 » create -p 4 test_create2
Creating table "test_create2" (AppID: 4)
Available partitions:
4 / 4 [----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00% 0 p/s 11s
Done!
Pegasus-AdminCli-1.2.0 » create test_create3
Creating table "test_create3" (AppID: 5)
Available partitions:
4 / 4 [----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00% 0 p/s 13s
Done!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants