Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix duplicating&learning(3/n): plog will be lost if decree is step back case when duplicating #765

Closed
Tracked by #766
foreverneverer opened this issue Jun 16, 2021 · 0 comments
Labels
duplicating&learning bug in duplicating while learning type/bug This issue reports a bug.
Milestone

Comments

@foreverneverer
Copy link
Contributor

foreverneverer commented Jun 16, 2021

Bug Report

for duplicating, if some log hasn't been confirmed, it will be reserve and send the potential secondary, the case which is named step back. for this case, we need resetlog files in /learn as current plog file in /plog, the origin code https://github.com/XiaoMi/rdsn/blob/v2.2/src/replica/replica_learn.cpp#L1526 point this. However, the reset_from is not been implemented correctly, XiaoMi/rdsn#845 is resolve the case.

Version

https://github.com/apache/incubator-pegasus/tree/v2.2.0-RC0

@foreverneverer foreverneverer added the type/bug This issue reports a bug. label Jun 16, 2021
@foreverneverer foreverneverer changed the title fix duplicating&learning(3/4): plog will be lost if decree is step back case when duplicating fix duplicating&learning(3/n): plog will be lost if decree is step back case when duplicating Jun 16, 2021
@foreverneverer foreverneverer added the duplicating&learning bug in duplicating while learning label Jun 16, 2021
@hycdong hycdong added this to the v2.3.0 milestone Aug 31, 2021
@hycdong hycdong closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicating&learning bug in duplicating while learning type/bug This issue reports a bug.
Projects
None yet
Development

No branches or pull requests

2 participants