Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor and optimize options for bloom filter #496

Closed
acelyc111 opened this issue Mar 12, 2020 · 0 comments · Fixed by #521
Closed

Monitor and optimize options for bloom filter #496

acelyc111 opened this issue Mar 12, 2020 · 0 comments · Fixed by #521

Comments

@acelyc111
Copy link
Member

acelyc111 commented Mar 12, 2020

Feature Request

Describe the feature you'd like:

We use 10 bits per key for bloom filter, it provide 1% false positive rate, but some user might need a lower FP rate, like 0.1%. We need to do some benchmark on it to check whether it would introduce some unacceptable memory and disk space waste.
And also, we need to monitor more metrics of BF.
https://github.com/facebook/rocksdb/wiki/RocksDB-Bloom-Filter

@acelyc111 acelyc111 added the type/enhancement Indicates new feature requests label Mar 12, 2020
@acelyc111 acelyc111 changed the title Monitor and optimize options od bloom filter Monitor and optimize options for bloom filter Mar 12, 2020
@acelyc111 acelyc111 added submodule/rocksdb and removed type/enhancement Indicates new feature requests labels Mar 12, 2020
@neverchanje neverchanje linked a pull request Apr 24, 2020 that will close this issue
acelyc111 pushed a commit that referenced this issue Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant