Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky unit test test_rename_path_while_writing #1631

Closed
acelyc111 opened this issue Sep 28, 2023 · 0 comments
Closed

Flaky unit test test_rename_path_while_writing #1631

acelyc111 opened this issue Sep 28, 2023 · 0 comments
Labels
type/bug This issue reports a bug.

Comments

@acelyc111
Copy link
Member

The unit test HDFSClientTest.test_rename_path_while_writing/0 is flaky:

[ RUN      ] HDFSClientTest.test_rename_path_while_writing/0
/__w/incubator-pegasus/incubator-pegasus/src/block_service/test/hdfs_service_test.cpp:457: Failure
Expected: (success_count) > (0), actual: 0 vs 0
0
[  FAILED  ] HDFSClientTest.test_rename_path_while_writing/0, where GetParam() = false (1 ms)
@acelyc111 acelyc111 added the type/bug This issue reports a bug. label Sep 28, 2023
@acelyc111 acelyc111 mentioned this issue Sep 28, 2023
Merged
empiredan pushed a commit that referenced this issue Oct 11, 2023
@acelyc111
fix(ut): fix flaky unit test test_rename_path_while_writing (#1630)
4cb6828 
#1631

Add retry logic for test `HDFSClientTest.test_rename_path_while_writing`, fix an
used-after-free ASAN issue and remove tar files after downloading from artifacts
to reduce space consumption.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug This issue reports a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acelyc111