Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb build flag caused the performance to degrade #1339

Closed
GehaFearless opened this issue Feb 7, 2023 · 1 comment
Closed

rocksdb build flag caused the performance to degrade #1339

GehaFearless opened this issue Feb 7, 2023 · 1 comment
Labels
type/bug This issue reports a bug.

Comments

@GehaFearless
Copy link
Contributor

Bug Report

Our business will introduce version 2.4 to replace 2.0，we found the 2.4 performance to be lower than 2.0.
For my work, I found the cause of the problem -- build type for one of thirdparty named rocksdb.
We lost flag "CMAKE_BUILD_TYPE=Release" on once Reconstruction.

rocksdb build type deleted by this commit: XiaoMi/rdsn@aef76b1#diff-74b3e476c2f3ca1dd3782cb2ef32bbf6b53adc54d8d961d829fdfd1523c433b8
@GehaFearless GehaFearless added the type/bug This issue reports a bug. label Feb 7, 2023
@GehaFearless GehaFearless mentioned this issue Feb 7, 2023
Merged
@GehaFearless
Copy link
Contributor Author

GehaFearless commented Feb 7, 2023 •
edited
Loading

Performance is 25% higher than before on the same machine when I apply this commit.

@empiredan empiredan mentioned this issue Dec 15, 2023
Merged
empiredan added a commit that referenced this issue Dec 15, 2023
@empiredan
fix: fix rocksdb build type (cherry-pick #1340) (#1775)
d404314 
#1339

RocksDB library is not built in Release version, which may cause terrible performance issues.

This PR is to cherry-pick #1340 into v2.4 to resolve #1339.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug This issue reports a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acelyc111 @GehaFearless