Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature(new_metrics): migrate table-level metrics #1327

Open
Tracked by #1325
empiredan opened this issue Jan 28, 2023 · 2 comments
Open
Tracked by #1325

Feature(new_metrics): migrate table-level metrics #1327

empiredan opened this issue Jan 28, 2023 · 2 comments
Labels
type/enhancement Indicates new feature requests

Comments

@empiredan
Copy link
Contributor

empiredan commented Jan 28, 2023 •
edited
Loading

There are following metrics all of which are in class replica, replica.cpp file:

_counters_table_level_latency[]

Therefore, table-level entity can just be defined in replica.cpp, where they are also instantiated in class replica, to which the above metrics are attached.

The table-level metrics originate from XiaoMi/rdsn#336 which is tracked by issue #406.
@empiredan empiredan added the type/enhancement Indicates new feature requests label Jan 28, 2023
@empiredan empiredan mentioned this issue Jan 28, 2023
Open
3 tasks
@acelyc111
Copy link
Member

Now that we can aggregate on collector, is it necessary to keep and aggregate these metrics on each replica server?

@empiredan
Copy link
Contributor Author

Now that we can aggregate on collector, is it necessary to keep and aggregate these metrics on each replica server?

OK, it's better to aggregate table metrics based on replica metrics, we can suspend this task.

@empiredan empiredan mentioned this issue Jun 13, 2023
Merged
empiredan added a commit that referenced this issue Jun 14, 2023
@empiredan
feat(new_metrics): remove all table-level perf-counters for each repl…
e4fa1aa 
…ica (#1531)

#1327

Remove all table-level metrics that are measured by perf-counters. Later,
table-level metrics would be aggregated by Go Collector, if necessary.
empiredan added a commit that referenced this issue Jun 21, 2023
@empiredan
feat(new_metrics): remove all table-level perf-counters for each repl…
eaff6ec 
…ica (#1531)

#1327

Remove all table-level metrics that are measured by perf-counters. Later,
table-level metrics would be aggregated by Go Collector, if necessary.
empiredan added a commit that referenced this issue Aug 9, 2023
@empiredan
feat(new_metrics): remove all table-level perf-counters for each repl…
89fb5b0 
…ica (#1531)

#1327

Remove all table-level metrics that are measured by perf-counters. Later,
table-level metrics would be aggregated by Go Collector, if necessary.
empiredan added a commit that referenced this issue Aug 11, 2023
@empiredan
feat(new_metrics): remove all table-level perf-counters for each repl…
38a280d 
…ica (#1531)

#1327

Remove all table-level metrics that are measured by perf-counters. Later,
table-level metrics would be aggregated by Go Collector, if necessary.
empiredan added a commit to empiredan/pegasus that referenced this issue Dec 6, 2023
@empiredan
feat(new_metrics): remove all table-level perf-counters for each repl…
23b1261 
…ica (apache#1531)

apache#1327

Remove all table-level metrics that are measured by perf-counters. Later,
table-level metrics would be aggregated by Go Collector, if necessary.
empiredan added a commit that referenced this issue Dec 11, 2023
@empiredan
feat(new_metrics): remove all table-level perf-counters for each repl…
8e3b1f0 
…ica (#1531)

#1327

Remove all table-level metrics that are measured by perf-counters. Later,
table-level metrics would be aggregated by Go Collector, if necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@empiredan @acelyc111