Apply suggestions from code review

Co-authored-by: Dan Wang <[email protected]>
apache · Feb 8, 2024 · f818d64 · f818d64
1 parent 449ef32
commit f818d64
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/src/runtime/rpc/dns_resolver.cpp b/src/runtime/rpc/dns_resolver.cpp
@@ -141,6 +141,4 @@ rpc_address dns_resolver::resolve_address(const host_port &hp)
     }
 }
 
-dns_resolver::~dns_resolver() { _dns_cache.clear(); }
-
 } // namespace dsn
diff --git a/src/runtime/rpc/dns_resolver.h b/src/runtime/rpc/dns_resolver.h
@@ -46,7 +46,7 @@ class dns_resolver : public utils::singleton<dns_resolver>
 
 private:
     dns_resolver();
-    ~dns_resolver();
+    ~dns_resolver() = default;
 
     friend class utils::singleton<dns_resolver>;
 

diff --git a/src/runtime/rpc/group_address.h b/src/runtime/rpc/group_address.h
@@ -55,7 +55,7 @@ class rpc_group_address : public ref_counter
     void set_leader(rpc_address addr);
     bool remove(rpc_address addr) WARN_UNUSED_RESULT;
     bool contains(rpc_address addr) const WARN_UNUSED_RESULT;
-    int count();
+    int count() const;
 
     const std::vector<rpc_address> &members() const { return _members; }
     rpc_address random_member() const
@@ -194,7 +194,7 @@ inline bool rpc_group_address::contains(rpc_address addr) const
     return _members.end() != std::find(_members.begin(), _members.end(), addr);
 }
 
-inline int rpc_group_address::count()
+inline int rpc_group_address::count() const
 {
     alr_t l(_lock);
     return _members.size();

diff --git a/src/runtime/test/host_port_test.cpp b/src/runtime/test/host_port_test.cpp
@@ -232,7 +232,7 @@ TEST(host_port_test, dns_resolver)
 {
     {
         host_port hp("localhost", 8080);
-        auto addr = dns_resolver::instance().resolve_address(hp);
+        const auto &addr = dns_resolver::instance().resolve_address(hp);
         ASSERT_TRUE(rpc_address("127.0.0.1", 8080) == addr ||
                     rpc_address("127.0.1.1", 8080) == addr);
     }
@@ -247,8 +247,8 @@ TEST(host_port_test, dns_resolver)
         host_port hp2("localhost", 8081);
         g_hp->set_leader(hp2);
 
-        auto addr_grp = dns_resolver::instance().resolve_address(hp_grp);
-        auto g_addr = addr_grp.group_address();
+        const auto &addr_grp = dns_resolver::instance().resolve_address(hp_grp);
+        const auto *const g_addr = addr_grp.group_address();
 
         ASSERT_EQ(g_addr->is_update_leader_automatically(), g_hp->is_update_leader_automatically());
         ASSERT_STREQ(g_addr->name(), g_hp->name());
-Original file line number
+Diff line change
@@ Expand Up @@
         }
     }
-    dns_resolver::~dns_resolver() { _dns_cache.clear(); }
     } // namespace dsn