This repository has been archived by the owner on Mar 9, 2023. It is now read-only.
BaseURL Configuration for MarvinAI Notebook #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added base url configuration for MarvinAI Notebook ex: marvin notebook --base-url=/marvin-notebook
Added test code fix
oldfly
reviewed
Sep 9, 2019
| @@ -29,15 +29,15 @@ def cli(): | |||
|
|
|||
| @cli.command('notebook', help='Start the Jupyter notebook server.') | |||
| @click.option('--port', '-p', default=8888, help='Jupyter server port') | |||
| @click.option('--base-url', '-p', default='/', help='Jupyter server base url') | |||
There was a problem hiding this comment.
The short parameter for base url could be something else than '-p' that conflicts with Port´s short parameter.
| @@ -69,7 +69,7 @@ def test_jupyter_lab(system_mocked, sys_mocked): | |||
| spark_conf = '/opt/spark/conf' | |||
| system_mocked.return_value = 1 | |||
|
|
|||
| lab(ctx, port, enable_security, spark_conf) | |||
| lab(ctx, port, '/', enable_security, spark_conf) | |||
|
|
|||
| system_mocked.assert_called_once_with('SPARK_CONF_DIR=/opt/spark/conf YARN_CONF_DIR=/opt/spark/conf jupyter-lab --notebook-dir /tmp/notebooks --ip 0.0.0.0 --port 8888 --no-browser --NotebookApp.token=') | |||
There was a problem hiding this comment.
Adding '--NotebookApp.base_url=/' for assertion error fix.
| @@ -83,6 +83,6 @@ def test_jupyter_lab_with_security(system_mocked, sys_mocked): | |||
| spark_conf = '/opt/spark/conf' | |||
| system_mocked.return_value = 1 | |||
|
|
|||
| lab(ctx, port, enable_security, spark_conf) | |||
| lab(ctx, port, '/', enable_security, spark_conf) | |||
|
|
|||
| system_mocked.assert_called_once_with('SPARK_CONF_DIR=/opt/spark/conf YARN_CONF_DIR=/opt/spark/conf jupyter-lab --notebook-dir /tmp/notebooks --ip 0.0.0.0 --port 8888 --no-browser') | |||
There was a problem hiding this comment.
Adding '--NotebookApp.base_url=/' for assertion error fix.
Wei-1
reviewed
Sep 9, 2019
| @@ -40,7 +40,7 @@ def test_notebook(system_mocked, sys_mocked): | |||
| spark_conf = '/opt/spark/conf' | |||
| system_mocked.return_value = 1 | |||
|
|
|||
| notebook(ctx, port, enable_security, spark_conf, allow_root) | |||
| notebook(ctx, port, '/', enable_security, spark_conf, allow_root) | |||
There was a problem hiding this comment.
I think it is better to still create a variable called base_url instead of directly put a '/' in the code.
Removed port conflict (-p) for base_url
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added base url configuration for MarvinAI Notebook
ex: marvin notebook --base-url=/marvin-notebook