Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1690: Apache KIE trademark character missing on Extended Services VS Code Extension's name #2810

Merged
merged 2 commits into from
Dec 16, 2024
Merged

kie-issues#1690: Apache KIE trademark character missing on Extended Services VS Code Extension's name #2810

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7438221
Fix vscode extension names
tiagobento Dec 15, 2024
8cdefcb
revert
tiagobento Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/extended-services-java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<groupId>org.kie.tools</groupId>
<artifactId>extended-services-java</artifactId>

<name>KIE Tools :: KIE Sandbox :: Extended Services Quarkus app</name>
<name>KIE Tools :: Extended Services Quarkus app</name>
<description
>Quarkus-based application that wraps Kogito JIT Executor for consumption as a KIE Sandbox backend.</description>

Expand Down
12 changes: 6 additions & 6 deletions packages/extended-services-vscode-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"engines": {
"vscode": "^1.67.0"
},
"displayName": "Apache KIE Extended Services",
"displayName": "Apache KIE™ Extended Services",
"categories": [
"Other"
],
Expand All @@ -62,13 +62,13 @@
{
"category": "Extended-Services",
"command": "extended-services-vscode-extension.startExtendedServices",
"title": "Connect Apache KIE Extended-Services",
"title": "Connect Apache KIE™ Extended Services",
"when": "extended-services-vscode-extension.connected"
},
{
"category": "Extended-Services",
"command": "extended-services-vscode-extension.stopExtendedServices",
"title": "Disconnect Apache KIE Extended-Services"
"title": "Disconnect Apache KIE™ Extended Services"
}
],
"configuration": {
Expand All @@ -94,22 +94,22 @@
"type": "string"
}
},
"title": "Apache KIE Extended Services"
"title": "Apache KIE™ Extended Services"
},
"icons": {
"extended-services-connected": {
"default": {
"fontCharacter": "\\E000",
"fontPath": "./static/extended-services-font.woff"
},
"description": "Connected to the Apache KIE Extended-Services"
"description": "Connected to the Apache KIE™ Extended Services"
},
"extended-services-disconnected": {
"default": {
"fontCharacter": "\\E001",
"fontPath": "./static/extended-services-font.woff"
},
"description": "Apache KIE Extended-Services are Disconnected"
"description": "Apache KIE™ Extended Services are Disconnected"
}
},
"languages": [
Expand Down
2 changes: 1 addition & 1 deletion packages/extended-services-vscode-extension/src/Validator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import * as validationRequests from "./requests/ValidationRequests";
import * as validationResponse from "./requests/ValidationResponse";
import * as vscode from "vscode";

const source: string = "Apache KIE Extended Services";
const source: string = "Apache KIE™ Extended Services";

function createBPMNDiagnostics(validationResponses: validationResponse.BPMNValidationResponse[]): vscode.Diagnostic[] {
return validationResponses.map((validationResponse) => {
Expand Down
2 changes: 1 addition & 1 deletion packages/extended-services-vscode-extension/src/configurations/Configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function fetchConnectionHeartbeatIntervalinSecs(): number {
function fetchExtendedServicesURL(): URL {
const extendedServicesURL = vscode.workspace.getConfiguration().get<string>(extendedServicesURLID);
if (!extendedServicesURL) {
throw new Error("Extended Services URL configuration not found");
throw new Error("URL configuration not found");
}

try {
Expand Down
6 changes: 3 additions & 3 deletions packages/extended-services-vscode-extension/src/extension/extension-browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ function initializeVSCodeElements() {

statusBarItem = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Right, 100);
statusBarItem.text = "$(extended-services-disconnected)";
statusBarItem.tooltip = "Apache KIE Extended Services are not connected. \n" + "Click to connect.";
statusBarItem.tooltip = "Apache KIE™ Extended Services is not connected. \n" + "Click to connect.";
statusBarItem.command = startExtendedServicesCommandUID;
statusBarItem.hide();

Expand Down Expand Up @@ -171,7 +171,7 @@ export function activate(context: vscode.ExtensionContext) {
if (configuration) {
validate(configuration);
statusBarItem.text = "$(extended-services-connected)";
statusBarItem.tooltip = "Apache KIE Extended Services are connected. Click to disconnect.";
statusBarItem.tooltip = "Apache KIE™ Extended Services is connected. Click to disconnect.";
statusBarItem.command = stopExtendedServicesCommandUID;
}
});
Expand All @@ -184,7 +184,7 @@ export function activate(context: vscode.ExtensionContext) {
connection.subscribeDisconnected(() => {
vscode.commands.executeCommand("setContext", connectedEnablementUID, false);
statusBarItem.text = "$(extended-services-disconnected)";
statusBarItem.tooltip = "Apache KIE Extended Services are not connected. Click to connect.";
statusBarItem.tooltip = "Apache KIE™ Extended Services is not connected. Click to connect.";
statusBarItem.command = startExtendedServicesCommandUID;
diagnosticCollection.clear();
});
Expand Down
4 changes: 2 additions & 2 deletions packages/extended-services-vscode-extension/src/extension/extension-main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ export function activate(context: vscode.ExtensionContext) {
if (configuration) {
validate(configuration);
statusBarItem.text = "$(extended-services-connected)";
statusBarItem.tooltip = "Apache KIE Extended Services are connected. Click to disconnect.";
statusBarItem.tooltip = "Apache KIE™ Extended Services are connected. Click to disconnect.";
statusBarItem.command = stopExtendedServicesCommandUID;
}
});
Expand All @@ -230,7 +230,7 @@ export function activate(context: vscode.ExtensionContext) {
connection.subscribeDisconnected(() => {
vscode.commands.executeCommand("setContext", connectedEnablementUID, false);
statusBarItem.text = "$(extended-services-disconnected)";
statusBarItem.tooltip = "Apache KIE Extended Services are not connected. Click to connect.";
statusBarItem.tooltip = "Apache KIE™ Extended Services are not connected. Click to connect.";
statusBarItem.command = startExtendedServicesCommandUID;
diagnosticCollection.clear();
});
Expand Down
2 changes: 1 addition & 1 deletion packages/serverless-workflow-vscode-extension/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"engines": {
"vscode": "^1.67.0"
},
"displayName": "KIE Serverless Workflow Editor",
"displayName": "Apache KIE™ Serverless Workflow Editor",
"categories": [
"Other"
],
Expand Down
Loading