Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-ISSUE: fix issue when using image digest in Operator Makefile #2804

Merged
merged 1 commit into from
Dec 13, 2024
Merged

NO-ISSUE: fix issue when using image digest in Operator Makefile #2804

merged 1 commit into from
Dec 13, 2024

Conversation

rgdoliveira
Copy link
Contributor

@rgdoliveira rgdoliveira commented Dec 12, 2024 •
edited
Loading

When using a digest for the operator (USE_IMAGE_DIGESTS=true), the separator between the image name and the tag should be an @ instead of a :

@rgdoliveira rgdoliveira requested review from ricardozanini and removed request for tiagobento December 12, 2024 20:48
domhanak
domhanak approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rgdoliveira rgdoliveira merged commit 5f57f14 into apache:main Dec 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domhanak domhanak domhanak approved these changes

@ricardozanini ricardozanini ricardozanini approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgdoliveira @ricardozanini @domhanak