-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #28
Update README.md #28
Conversation
@jschuler Since you've been recently experimenting with this repo, I requested your review as well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 Suggestions that could make it neater imho.
otherwise looks good. :)
README.md
Outdated
-------------------- | ||
|
||
##### VSCode Extension | ||
1. After you've built following the instructions above, open the `packages/vscode-extension-pack-kogito-kie-editors` folder on VSCode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestions in bold
After you've successfully built the project following the instructions above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be more specific:
open the ... folder in a new VSCode window so that the folder shows up at the root in the VSCode explorer
README.md
Outdated
3. **Remember!** If you make changes to packages other than `packages/vscode-extension-pack-kogito-kie-editors`, you have to manually rebuild them before relaunching the extension on VSCode. | ||
|
||
##### Chrome Extension | ||
1. After you've built following the instructions above, open the `packages/chrome-extension-pack-kogito-kie-editors` folder on your favourite IDE. You can import the entire repo as well if you want to make changes to other packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same suggestion as above
suggestions in bold
After you've successfully built the project following the instructions above
1. Build with Yarn: | ||
```bash | ||
cd kogito-tooling | ||
yarn run init |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically yarn
commands don't need the run
part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah.. but they say that lifecycle scripts will take precedence over the custom scripts.. if you run yarn init
it will do something else and not run our "init" script.
README.md
Outdated
-------------------- | ||
|
||
##### VSCode Extension | ||
1. After you've built following the instructions above, open the `packages/vscode-extension-pack-kogito-kie-editors` folder on VSCode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be more specific:
open the ... folder in a new VSCode window so that the folder shows up at the root in the VSCode explorer
README.md
Outdated
|
||
##### VSCode Extension | ||
1. After you've built following the instructions above, open the `packages/vscode-extension-pack-kogito-kie-editors` folder on VSCode. | ||
2. From there, you can Run the extension or the integration tests by using the `Debug` menu/section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or by pressing the F5 key
|
||
##### Chrome Extension | ||
1. After you've built following the instructions above, open the `packages/chrome-extension-pack-kogito-kie-editors` folder on your favourite IDE. You can import the entire repo as well if you want to make changes to other packages. | ||
2. Open a terminal and run `yarn run serve-envelope` on `packages/chrome-extension-pack-kogito-kie-editors`. This will start a `webpack-dev-server` instance with the editors and their envelope. We use that because we don't pack the Chrome Extension bundle with the editors inside. Instead, we fetch them from GitHub pages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about the artifacts, are they included somewhere or we have to manually download them?
…emoved errai-jboss-as-support removed
* Add note in the Kafka settings tab * Method to retrieve access token for Service Registry * Make listing a table * Fix header * Method to upload OpenAPI to Service Registry * Remove unused imports * Add button for tests and some fixes/improvements * Check for openshift connection * Use Basic auth instead of OAuth when uploading to service registry * Remove test button * Upload OpenAPI to Service Registry if the file has not been stored yet * Keep fetching the OpenAPI until the deployment is up * Minor improvements to the deploy * Fetch artifacts * Fix deploy without Kafka * Remove some unnecessary dependencies * Workaround undo/redo issue * Disable kie-sandbox-fs tests * Disable noImplicitAny * Add informative text to Settings items * Disable deploy button if the diagram is already deployed * Delete OpenAPI file from FS if the deployment is deleted on OpenShift * Improve Settings tabs a little bit more * Add services to editor autocomplete * Remove temp button * Remove slashes from artifact ids * Remove single quote from text * Reverted removed theme undefined check. * Add setTimeout to avoid blank graphical editor * Create repository with Kogito Quarkus project * Replace slashes and spaces by underscores for artifact ids * Remove Create Gist item * Fix workflow path after creating a GitHub repository * Fix alert layout * Update Quarkus to 2.8.0.Final on the Serverless Workflow base container file * Prepare initial structure for SWF Sandbox (derived from swf-chrome-extension) * High level reorganization * Convert code to KIE Sandbox: Home * Convert code to KIE Sandbox: EditorToolbar * Fix Service Registry access and the Rename operation. Also remove some unnecessary stuff. * Convert code to KIE Sandbox: Add Sample * Fix console errors thrown by Monaco * Convert code to KIE Sandbox: Loading editor * Remove extra scroll from the editor * Simplify OpenShiftContext * Add buttons for creating dashboards * Add SVG when deploying the workflow * Add dropdown for deployments * Convert code to KIE Sandbox: Env vars * Alow any non-model file to be opened in a readonly text editor * Add support for YML/YAML files * Be able to open files like .gitignore * Bring back settings as a modal * Fix yarn.lock after merge with main * Be able to open files without extension * Fix undo and redo * Remove undo/redo workaround * Simplify OpenShiftService * Showcase * Add samples * Showcase list * Organize samples * Add third example and descriptions * Improve cards * Show samples by default * Update Proxy URL * Remove accordion * Use extended services * Default to hosted extended services * Remove dmnRunner references * Initial support for serverless decision files * Move text editor to its own package * Copy env.json file * Update extensions for serverless decision * Stop using editorEnvelopeLocator for file filtering while we have an envelope for all files * Allow serverless decision files to be deployed, though not supported by the base container image yet * Fix upload file * Remove padding from deploy button * Convert YAML to JSON before deploying * Enable users to create both yaml and json files * Update page title * Adjustments after sync with main * Add full project as sample and horizontal scroll * Turn into local workspace * Use Quarkus template only if the workspace is not a project * Make Download SVG only available to serverless workflow files * Fixes after pnpm migration * Implements sandbox api * Load function from service-registry again * Remove unused code and imports * Add missing dependencies * Dashbuilder on SWF Sandbox (#21) * Remove comment * Remove log * Workaround duplicated monaco issue for now * Fix build:prod * Remove unnecessary dependency * Compile gwt even for build:dev script * Initial tag to represent projects * Editor fixes and dashboard samples (#23) * Update graph.dot * Remove workaround for Monaco * Fix path to dashbuilder-runtime-client * Don't repeat functions * Fix pnpm-lock file after sync * Remove alias no longer necessary * Don't get duplicate add functions * Improve showcase labels * Replace yarn by pnpm * Update package.json (#25) Fix copying setup.js * Bold tag * Add notification stuff from KIE Sandbox * Remove duplicated package on .syncpackrc.json * Updates after sync with main * Add deploy-related stuff from KIE Sandbox * No need to send the preview when deploying anymore * Upload OpenAPI to Service Registry only if config is set * Remove extra scrollbar * Fix some strings * Fix swf base image package and bump versions * Ignore WEB-INF folder when copying dashbuilder bundle * Avoid unnecessary calls to service catalog * Reintroduce distinction between model and other files * Add KieSandboxExtendedServicesModal from KIE Sandbox * Standardize settings tabs * Enable multifile deployments * Fix some connection issues * Add advanced options to confirm deploy modal * Update KafkaSource resource to follow OpenShift changes * Minor fixes * Update message * Minor fixes * Clean up swf services to avoid unnecessary calls while navigating on settings * Clean up * Reuse LoadingSpinner * Improve advanced options * Update samples * Disconnect OpenShift in case of polling errors * Remove unnecessary resources * Simplify resources a bit * Fix message * Bump Quarkus platform version * Rename base image package * Rename base image folder * Rename env vars and constants * A pom.xml file in the root folder makes the workspace be treated as a project when applicable * Identify task related with enabling notifications * Remove commented code taken from KIE Sandbox * Centralize extension-related code * Refactor SwfServiceCatalogStore and refresh catalog store after a new upload * Add yard sample to new file dropdown * Change dev port number to 9020 * Update pnpm lock file * Rename path dashbuilder-runtime-client -> dashbuilder-client * KOGITO-7329: Default Dashboard for SWF Sandbox Deployment (#28) * KOGITO-7320: Publish Dashbuilder Client bundle to NPM * Updating lockfile * KOGITO-7329: Default Dashboard for SWF Sandbox Deployment * Adding the dashboard to the base image * updating pnpm lock * Fixes * removing unused files * updating pnpm lock * Update graph.dot * Minor improvements * Add basic webapp for serverless logic sandbox deployments * Update file header * Enable validation for swf json files * Rename package: @kie-tools/swf-sandbox -> @kie-tools/serverless-logic-sandbox (not the folder yet) * Standardize cookie names * Rename folder: swf-sandbox -> serverless-logic-sandbox * Remove Temperature conversion sample for now * Update Quarkus accelerator repository * Remove Create Gist while it does not work properly * Adapt CI * Fix SERVERLESS_LOGIC_SANDBOX__baseImageAccount * Fix extended services host/port * Setup GTM * Compilation fixes after sync with main * Fix warning: Potentially unsafe external link * Add missing dev dependency * Test building dashbuilder on all platforms * Fix Dashbuilder scripts for Windows OS * Dashbuilder: skip tests on windows/mac for now * Fix Dashbuilder authoring/runtime scripts * Remove comment * Use relative path on swf-report sample * Do not build dashbuilder authoring on Windows * Do not build dashbuilder runtime on Windows * Do not zip dashbuilder authoring/runtime on Windows * Create empty file with touch * Minor improvements * Add Virtual Service Registry (#34) * Init virtual path * Rename context * Provider * Adds apicurio docker-compose * Map all functions * Filling services * New VirtualServiceRegistry service * Remove old provider * Preliminary tests with virtual service registry * Preview virtual registry files * Catalog fixes * Correctly deleting registry files and ignoring empty ones * Rename folder * Abstract FsService and DescriptorService * Fixed import and lockfile * Revert TextEditor and move apicurio docker-compose * Remove duplicated dependency * If not SWF, set editor ready * Wait for apiImpl only for sw.json files * Add spec files to virtual service registry * Use stateControl from props when available * Fix undo command on DashbuilderEditor * Minor improvements to Settings tabs * KOGITO-7447: Allow workflow to import specs from other files in same workspace (but not itself) (#36) * Init virtual path * Rename context * Provider * Adds apicurio docker-compose * Map all functions * Filling services * New VirtualServiceRegistry service * Remove old provider * Preliminary tests with virtual service registry * Preview virtual registry files * Catalog fixes * Correctly deleting registry files and ignoring empty ones * Rename folder * Abstract FsService and DescriptorService * Fixed import and lockfile * Revert TextEditor and move apicurio docker-compose * Make same workspace files work as local files and filter out same workflow spec * Enable single-module project deployment * List functions without extended services * Fix labels * Minor improvements to Settings tabs * Remove samples and add Compensation sample * Prepare for integration with stunner * Enable 'deploy as project' as default if applicable * Set a fixed build tag version instead of latest * [NOISSUE] Adds browser alert and fixes diagram for Firefox (#38) * Check browser to add alert and increase timeout for updating diagram (fixes for Firefox) * Revert dashbuilder-client build for Windows * Simplify browser check * [KOGITO-7467]: Create BaseService class to be used by WorkspaceService and VirtualServiceRegistryService (#37) * Init virtual path * Rename context * Provider * Adds apicurio docker-compose * Map all functions * Filling services * New VirtualServiceRegistry service * Remove old provider * Preliminary tests with virtual service registry * Preview virtual registry files * Catalog fixes * Correctly deleting registry files and ignoring empty ones * Rename folder * Abstract FsService and DescriptorService * Fixed import and lockfile * Revert TextEditor and move apicurio docker-compose * Make same workspace files work as local files and filter out same workflow spec * BaseService * BaseService for VirtualServiceRegistryService * KOGITO-7467: Make BaseService and use it for WorkspaceService and VirtualServiceRegistryService * Bump Quarkus platform version * Remove .vscode settings from gitignore * Apply kogito.yml during OpenShift build when deploying as a project * Fix curl output * Skip cleanup and copy assets on Windows since it does not build anyway * Move get-oc script to Containerfile * Use font 12 on Monaco for Dashbuilder * Use insecure-skip-tls-verify on oc login * Applied same fix for monaco-yaml done in KOGITO-7519 * Integrate Stunner and Sandbox * Use our deployed cors-proxy as default value * Use relative path Co-authored-by: Thiago Lugli <[email protected]> Co-authored-by: Paulo Martins <[email protected]> Co-authored-by: Thiago Lugli <[email protected]> Co-authored-by: William Antônio Siqueira <[email protected]> Co-authored-by: Thiago Lugli <[email protected]>
* KOGITO-7320: Publish Dashbuilder Client bundle to NPM * Updating lockfile * KOGITO-7329: Default Dashboard for SWF Sandbox Deployment * Adding the dashboard to the base image * updating pnpm lock * Fixes * removing unused files * updating pnpm lock
…ow:sonataflow-quarkus-devui version (apache#28)
… v0.8 (apache#28) Signed-off-by: Davide Salerno <[email protected]>
…stry-for-swf-devmode-image NO-ISSUE: Add swf devmode env vars for quay.io
Adding instructions to development.