kie-issues#2549: Decision Service cannot be recognized in columns of decision table #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielzhe
force-pushed
the
ds-in-columns
branch
from
a6def1b to
776efaa
Compare
jomarko
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Thank you @danielzhe , during my manual check, I didn't find an issue. I put some comments to code inline. Please let me know what do you think about them.
| import * as fs from "fs"; | ||
| import * as path from "path"; | ||
| import { getMarshaller } from "@kie-tools/dmn-marshaller"; | ||
| //import {getMarshaller} from "@kie-tools/dmn-marshaller/d" |
Comment on lines
+376
to
+378
| for (let i = 0; i < expected.length; i++) { | ||
| expect(semanticMonacoTokens?.data[i]).toEqual(expected[i]); | ||
| } |
There was a problem hiding this comment.
can't we simplify?:
expect(semanticMonacoTokens?.data).toEqual(expected)
There was a problem hiding this comment.
No, their types are different and it fails if we do this way:
Error: expect(received).toEqual(expected) // deep equality
Expected: [0, 0, 20, 6, 0, 0, 21, 10, 5, 0, …]
Received: serializes to the same string
<Click to see difference>
tiagobento
reviewed
Oct 22, 2024
| @@ -377,3 +524,8 @@ function createModelMockForExpression(expression: string) { | |||
| getLinesContent: jest.fn().mockReturnValue(expression.split("\n")), | |||
| }; | |||
| } | |||
|
|
|||
| function getDmnModelFromFilePath(filePath: string) { | |||
There was a problem hiding this comment.
|
@jomarko @tiagobento Changes applied! Ready for you. |
tiagobento
approved these changes
Oct 29, 2024
ricardozanini
pushed a commit
to ricardozanini/kogito-tooling
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2549
It closes the ticket related to the colorize and autocomplete only.
ds-fix.mp4