Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Set locale to "en-US" before generating image-builder and run-script-if READMEs #2444

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

ljmotta
Copy link
Contributor

@ljmotta ljmotta commented Jun 21, 2024

Adding this prevent yargs of using the machine locale.

@ljmotta ljmotta requested a review from tiagobento as a code owner June 21, 2024 18:43
@ljmotta ljmotta requested review from thiagoelg and tiagobento and removed request for tiagobento June 21, 2024 18:44
@tiagobento
Copy link
Contributor

What problem does this solve? I get that this pins the locale, but why do we need that?

@ljmotta
Copy link
Contributor Author

ljmotta commented Jun 21, 2024

@tiagobento yargs --help is used to write the the image-builder and run-script-if README files. By default yargs use the machine locale, so in my case it was en-BR, which re-writed the files using Portuguese.

@tiagobento
Copy link
Contributor

Maybe instead of hardcoding it to all the invocations of image-builder and run-script-if, we could simply foce the locale in the invocations specific to building the READMEs, no?

@tiagobento
Copy link
Contributor

I mean, defining a locale is pretty out of scope for run-script-if and image-builder.

@ljmotta ljmotta changed the title NO-ISSUE: Add en-US locale to yargs NO-ISSUE: Set locale to "en-US" before generating image-builder and run-script-if READMEs Jun 22, 2024
@ljmotta ljmotta self-assigned this Jun 24, 2024
@ljmotta ljmotta added the pr: waiting-for-review Waiting for peer reviews label Jun 24, 2024
@tiagobento tiagobento merged commit 6c339f3 into apache:main Jun 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: waiting-for-review Waiting for peer reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants