NO-ISSUE: sonataflow-operator: generate stable names for workflow resources #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgolangh
force-pushed
the
main
branch
2 times, most recently
from
ea7e605 to
a4fa9cf
Compare
ricardozanini
approved these changes
May 27, 2024
There was a problem hiding this comment.
Can you also please backport this change to https://github.com/apache/incubator-kie-kogito-serverless-operator/?
tiagobento
added
pr: DO NOT MERGE
|
|
There seems to be tests failing... |
tiagobento
changed the title
Motivation: Workflowproj generates a configmap per schema or subflow or specs in a separate file for each one, however the name is not deterministic. In one iteration you can get the specs in 01-configmap-FLOWNAME-resources.yaml and in the next iteration the same content will go in 02-configmap-FLOWNAME-resources.yaml. While the flow spec file will be updated accordingly and stay correct, the behaviour generates lots of changes when tracking changes in git. Modification: This fix will make the generation behaviour deterministic by sorting the resources iteration prior to generating them and also add the related schemas|specs/subflows to the generated file name: Result: old schema configmap manifest: 0x-configmap-FLOWNAME-resources.yaml new schema configmap manifest: 01-configmap-FLOWNAME-resources-schemas.yaml old specs config map manifest: 0x-configmap-FLOWNAME-resources.yaml new specs configmap manifest: 02-configmap-FLOWNAME-resources-specs.yaml old subflows config map manifest: 0x-configmap-FLOWNAME-resources.yaml new subflows configmap manifest: 01-configmap-FLOWNAME-resources-subflows.yaml Also the name of the config map itself will get the name related to the content like: '03-FLOWNAME-resources-schemas' Signed-off-by: Roy Golan <[email protected]>
|
I fixed the unsorted imports now, they look exactly as the PR to the operator apache/incubator-kie-kogito-serverless-operator#473 |
|
@tiagobento @ricardozanini can you please merge this? |
tiagobento
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Workflowproj generates a configmap per schema or subflow or specs in a
separate file for each one, however the name is not deterministic. In
one iteration you can get the specs in
01-configmap-FLOWNAME-resources.yaml and in the next iteration the same
content will go in 02-configmap-FLOWNAME-resources.yaml.
While the flow spec file will be updated accordingly and stay correct,
the behaviour generates lots of changes when tracking changes in git.
Modification:
This fix will make the generation behaviour deterministic by sorting the
resources iteration prior to generating them and also add the related
schemas|specs/subflows to the generated file name:
Result:
old schema configmap manifest:
0x-configmap-FLOWNAME-resources.yaml
new schema configmap manifest:
01-configmap-FLOWNAME-resources-schemas.yaml
old specs config map manifest:
0x-configmap-FLOWNAME-resources.yaml
new specs configmap manifest:
02-configmap-FLOWNAME-resources-specs.yaml
old subflows config map manifest:
0x-configmap-FLOWNAME-resources.yaml
new subflows configmap manifest:
01-configmap-FLOWNAME-resources-subflows.yaml
Also the name of the config map itself will get the name related to the
content like: '03-FLOWNAME-resources-schemas'
Signed-off-by: Roy Golan [email protected]