kie-issues#937: On the DMN Editor, adding a DRD then pressing "Undo", makes the Editor will crash #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagobento
approved these changes
May 7, 2024
ljmotta
added
pr: waiting-for-review
yesamer
approved these changes
May 8, 2024
porcelli
approved these changes
May 8, 2024
There was a problem hiding this comment.
I understand that we still don't have the proper setup to add to this PR a test coverage that would prevent this issue in the future.
this is tracked by this apache/incubator-kie-issues#1174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#937
Description
This PR changes the
diagram.drdIndextodiagram.__unsafeDrdIndex. Now, to retrieve thedrdIndexit's required to use the computedgetDrdIndex()method. This method will check if the current__unsafeDrdIndexis pointing to a valid DRD index. In a positive case, it will return the current value. Otherwise, it will return the last available index.