Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1163: incubator-kie-tools missing header files #2298

Merged
merged 14 commits into from
May 8, 2024

Conversation

yesamer
Copy link
Contributor

@yesamer yesamer commented May 7, 2024

@yesamer yesamer added the pr: DO NOT MERGE Draft PR, not ready for merging label May 7, 2024
@yesamer yesamer removed the pr: DO NOT MERGE Draft PR, not ready for merging label May 8, 2024
@porcelli porcelli requested a review from LightGuard May 8, 2024 12:05
@Josephblt Josephblt self-requested a review May 8, 2024 13:59
@yesamer
Copy link
Contributor Author

yesamer commented May 8, 2024

@porcelli @LightGuard DISCLAIMER added.

@Josephblt Josephblt self-requested a review May 8, 2024 14:54
Josephblt

This comment was marked as outdated.

@Josephblt Josephblt self-requested a review May 8, 2024 16:15
Josephblt

This comment was marked as outdated.

Copy link
Member

@Josephblt Josephblt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @yesamer. I used a bash script (check_header.sh) to check the headers using the kie-tools-rad-report file.

check_header.sh
kie-tools-rad-report.txt

To use the script:
Paste the file check_header.sh to kie-tools directory
Paste the file kie-tools-rad-report.txt to kie-tools directory
Run check_headers script ($./{kie-tools directory}/./check_header.sh.

Here is the list of files without headers I found:
results.txt
Although it is possible that some of the files could be ignored, there are lots of .java files that are likely to be problematic.

@yesamer
Copy link
Contributor Author

yesamer commented May 8, 2024

Thank you @Josephblt for checking!!
I intentionally ignored some java files because:

  • In dashbuilder, a set of java files are used to test a code generation feature, and adding the headers leads to some tests failures
  • Some java class file are a copy from other libraries. In such a case I don't know how to handle that

In any case, I'll double check again

@porcelli porcelli merged commit 97c01c8 into apache:main May 8, 2024
14 checks passed
@yesamer yesamer deleted the headers branch May 8, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incubator-kie-tools missing header files
5 participants