kie-issues#793: The keyboard shortcuts panel doesn't show the new DMN Editor keyboard shortcuts #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomarko
approved these changes
May 2, 2024
tiagobento
requested changes
May 3, 2024
There was a problem hiding this comment.
Simple change on the default behavior for shortcuts... Not sure if it makes sense, though. I always prefer throwing than silently failing, though.
Anyway, also please create an issue for tests to be added to each shortcut individually. Thanks @ljmotta. Great implementation!
Comment on lines
49
to
61
| hideFromDrd: () => {}, | ||
| toggleHierarchyHighlight: () => {}, | ||
| togglePropertiesPanel: () => {}, | ||
| createGroup: () => {}, | ||
| selectAll: () => {}, | ||
| panDown: () => {}, | ||
| panUp: () => {}, | ||
| paste: () => {}, | ||
| copy: () => {}, | ||
| cut: () => {}, | ||
| cancelAction: () => {}, | ||
| focusOnSelection: () => {}, | ||
| resetPosition: () => {}, |
There was a problem hiding this comment.
Maybe the default should be throwing an error? I mean, none of these should ever be a no-op.
|
if there is a ticket/epic for tests, please share a link with us, thank you @ljmotta |
|
@jomarko @tiagobento I've incorporated the review and I've created the issue apache/incubator-kie-issues#1155 |
tiagobento
changed the title
tiagobento
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#793
Description
Move the keyboard shortcuts to the DMN Editor envelope.
keyboard-shortcuts.mp4