Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#963: Move task-console and management-console images from kogito-images to kie-tools #2226

Merged
merged 20 commits into from
Apr 12, 2024

Conversation

thiagoelg
Copy link
Member

@thiagoelg thiagoelg commented Apr 4, 2024

Closes: apache/incubator-kie-issues#963
Closes: apache/incubator-kie-issues#1037

In this PR:

  • Added kogito-management-console image package
  • Added kogito-task-console image package
  • Added README for runtime-tools-management-console-webapp
  • Added README for runtime-tools-task-console-webapp
  • Added Keycloak configs and instructions for both webapps
  • Added new env vars for both webapps
  • Injected env vars to window object so dependencies can invoke them

Images are based on the kie-sandbox-image Containerfile and scripts, using Apache httpd to serve static files.

Env vars are generated and injected using image-env-to-json-standalone.

@thiagoelg thiagoelg changed the title Move task-console and management-console images from kogito-images to kie-tools kie-issues#963: Move task-console and management-console images from kogito-images to kie-tools Apr 4, 2024
thiagoelg and others added 4 commits April 4, 2024 17:00
* Added missing PatternFly Addons CSS in Consoles
* Fixes in `JobManagementTable` (removed select & actions columns when table is empty)
… and runtime-tools-management-console-webapp-image to kogito-management-console
@thiagoelg thiagoelg requested a review from rodrigonull April 9, 2024 16:01
@thiagoelg
Copy link
Member Author

@rodrigonull adding you as reviewer, mainly due to the new Jenkins tasks :)

Copy link
Contributor

@rodrigonull rodrigonull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Jenkins jobs LGTM.

@tiagobento tiagobento changed the title kie-issues#963: Move task-console and management-console images from kogito-images to kie-tools kie-issues#963: Move task-console and management-console images from kogito-images to kie-tools Apr 10, 2024
Comment on lines -37 to -42
},
"kieTools": {
"requiredPreinstalledCliCommands": [
"java",
"mvn"
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup. Thx!

@tiagobento tiagobento requested a review from pefernan April 11, 2024 21:20

ARG KOGITO_MANAGEMENT_CONSOLE_PORT=8080

ENV RUNTIME_TOOLS_MANAGEMENT_CONSOLE_KOGITO_ENV_MODE="PROD"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tiagobento tiagobento merged commit ed8531d into apache:main Apr 12, 2024
8 checks passed
fantonangeli pushed a commit to fantonangeli/kie-tools that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants