-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#966: Move the BPMN Quarkus Dev UI package from kogito-apps
to kie-tools
#2223
Conversation
kogito-apps
to kie-tools
kogito-apps
to kie-tools
packages/maven-base/pom.xml
Outdated
<quarkus.platform.version>3.2.9.Final</quarkus.platform.version> | ||
<version.org.kie.kogito>999-20240218-SNAPSHOT</version.org.kie.kogito> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of hard coding the dependencies version here, I think we should be reusing the values from env
. There's other packages doing this.. See https://github.com/apache/incubator-kie-tools/blob/main/packages/dev-deployment-kogito-quarkus-blank-app/install.js
8ec2358
to
0e0dcec
Compare
uniformed style following apache#2223
@pefernan I see there are changes done to |
@pefernan I just remembered something. For Maven packages to successfully be installed and not require the -D properties we require during the build, we need to run a Maven plugin called |
right! |
9579bc5
to
385ef95
Compare
…s` to `kie-tools` (apache#2223)
Closes apache/incubator-kie-issues#966
This PR brings the
jbpm-quarkus-devui
maven modules fromkogito-apps
intokie-tools
. It includes the following changes:@kie-tools/maven-base
package to be used as a parent for all the maven-based packages in kie-tools.TaskForm
component that was affecting thejbpm-quarkus-devui
.