Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#1012: Removing kie-soup-commons dependency in DashBuilder #2199

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

yesamer
Copy link
Contributor

@yesamer yesamer commented Mar 14, 2024

Closes apache/incubator-kie-issues#1012

Dashbuild still depends on a 7.59.0 version of kie-soup-commons.
That dependency is required to perform null (and empty) checks on Objects only, so we can safely remove it and replace it with native Java API.

@yesamer yesamer added pr: DO NOT MERGE Draft PR, not ready for merging area:dashbuilder labels Mar 14, 2024
@yesamer yesamer changed the title NO-ISSUE: Removing kie-soup-commons dependency in DashBuilder NO-ISSUE: Removing kie-soup-commons dependency in DashBuilder Mar 14, 2024
Copy link
Member

@porcelli porcelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job @yesamer - towards a sustainable codebase!

@yesamer yesamer changed the title NO-ISSUE: Removing kie-soup-commons dependency in DashBuilder kie-issues#112: Removing kie-soup-commons dependency in DashBuilder Mar 15, 2024
@yesamer yesamer added area:dependencies Pull requests that update a dependency file and removed pr: DO NOT MERGE Draft PR, not ready for merging labels Mar 15, 2024
@yesamer yesamer changed the title kie-issues#112: Removing kie-soup-commons dependency in DashBuilder kie-issues#1012: Removing kie-soup-commons dependency in DashBuilder Mar 15, 2024
@tiagobento tiagobento merged commit 013f7f7 into apache:main Mar 15, 2024
8 checks passed
@yesamer yesamer deleted the dashbuilder-kie-soup branch March 15, 2024 16:58
paulovmr pushed a commit to kiegroup/kie-tools that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dashbuilder area:dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing kie-soup-commons dependency in DashBuilder
4 participants