kie-issues#946: Action plan - Exploratory phase of the strategy for implementing the E2E test suite for the new DMN Editor - Part 2 #2189
Conversation
* introduce deleteNodes.spec.ts * Refactor 'delete' * Run all delete node tests * finalize delete mutation test suite
* Introduce deleteEdge.spec.ts * Remove 'only' * test both backspace and delete * split delete edge spec
* Introduce addWaypoint.spec.ts * clean up imports * Fix imports * refactor addEdgeWaypoint.spec.ts --------- Co-authored-by: Luiz João Motta <[email protected]>
| dmnEditor: { | ||
| storybook: { | ||
| port: 9901, |
There was a problem hiding this comment.
Are all ports on env/index.js files defined as strings? I know this had the color bug with the special characters and everything, but it's really bugging me that this could be the only place where we need these numbers to be defined as strings...
There was a problem hiding this comment.
The problem is happening because we use the STORYBOOK_BASE env variable inside the storybook wrapper. We set the env variable on the start script and them it's used inside the storybook-base bin, thus the terminal color. I choose this approach as I had some problems evaluating the build-env boxedExpressionComponent.storybook.port on Windows due to quotes and double quotes. I guess I need to revist this problem. Anyway, this change should affect only components that use storybook.
| @@ -239,20 +239,19 @@ export const InputDataNode = React.memo( | |||
| onDoubleClick={triggerEditing} | |||
| onKeyDown={triggerEditingIfEnter} | |||
| style={alternativeSvgStyle} | |||
| className={selectedAlternativeClass} | |||
| className={`kie-dmn-editor--node ${selectedAlternativeClass}`} | |||
There was a problem hiding this comment.
There's one "kie-dmn-editor--node" inside another "kie-dmn-editor--node"?
tiagobento
changed the title
…mplementing the E2E test suite for the new DMN Editor - Part 2 (apache#2189) Co-authored-by: Jozef Marko <[email protected]>
Related to apache/incubator-kie-issues#946
This PR continues the exploratory phase and continue the work started on #2158
Description
This PR creates introduce and fix a few things:
boxed-expression-componentanddmn-editorenv files. Depending of the terminal the number comes formated with color, causing the server starting with a random port.data-testidintroduced on kie-issues#946: DMN Editor playwright test suite - part 1 - initialization #2158data-nodehrefanddata-nodelabelto help selecting elements on the E2E tests.OutgoingStuffNodePanel.editor,palette,nodes,edgesPlaywright fixturesImprovements for the next interation