KOGITO-10042: Migrate Dev UI Java module from kogito-apps to kie-tools #2167

fantonangeli · 2024-02-20T17:16:50Z

Jira: https://issues.redhat.com/browse/KOGITO-10042

Description:
The kogito-quarkus-serverless-workflow-devui-parent module should be migrated to apache/incubator-kie-tools while being renamed to sonataflow-serverless-workflow-devui. Its children modules can have the parent module name removed from its prefix, resulting in the deployment and runtime modules.

Important:

It seems not possible to remove the prefix from the sub-modules as the deployment module cannot find the runtime module during the quarkus execution, because quarkus composes the name in the way "{runtime}-deployment".
This PR already gets the commits from kie-issues#960: Upgrade kie-tools to Java 17, Maven 3.9.6, and Quarkus 3 #2182 to compile with Java 17, Maven 3.9.6, and Quarkus 3
This PR uses the new GAV org.apache.kie.sonataflow:sonataflow-serverless-workflow-devui

How to test:

Test with mvn 3.9.6 and java 17
pnpm -F @kie-tools/sonataflow-quarkus-devui-extension-parent... build:dev
Open a kogito-example eg. https://github.com/apache/incubator-kie-kogito-examples/tree/stable/serverless-workflow-examples/serverless-workflow-greeting-quarkus , using the main branch
in pom.xml, replace the following dependency:

    <dependency>
      <groupId>org.kie.kogito</groupId>
      <artifactId>sonataflow-quarkus-devui</artifactId>
    </dependency>

with:

    <dependency>
      <groupId>org.apache.kie.sonataflow</groupId>
      <artifactId>sonataflow-quarkus-devui-extension</artifactId>
      <version>0.0.0</version>
    </dependency>

and add:

  <repositories>
    <repository>
      <!-- Duplicating the Maven Central repository here (as it is already coming from Super POM) makes the build much faster,
           as the Maven Central is now treated as the first (default) repository (because it is before the Apache Nexus one).
           Artifacts with release (fixed) versions are being downloaded primarily from there. Without the central being the
           first repository the Apache Nexus would be contacted first and since it is quite slow it slows down the build.
           We use Apache repo only to download our SNAPSHOTs. -->
      <id>central</id>
      <name>Central Repository</name>
      <url>https://repo.maven.apache.org/maven2</url>
      <layout>default</layout>
      <snapshots>
        <enabled>false</enabled>
      </snapshots>
    </repository>
    <repository>
      <id>apache-public-repository-group</id>
      <name>Apache Public Repository Group</name>
      <url>https://repository.apache.org/content/groups/public/</url>
      <releases>
        <enabled>true</enabled>
        <updatePolicy>never</updatePolicy>
      </releases>
      <snapshots>
        <enabled>true</enabled>
        <updatePolicy>daily</updatePolicy>
      </snapshots>
    </repository>
  </repositories>

Preview:
KOGITO-10042-devui.webm
KOGITO-10042-devui-v1.webm

…d with JDK 12+)

…nd `999-20240225-SNAPSHOT`

paulovmr · 2024-03-08T20:26:32Z

Tested locally and it is working, great job @fantonangeli !

Just to confirm, we probably need @tiagobento or @rodrigonull input here (sorry if you talked about this already), what groupId should we use for these artifacts? Currently it is org.apache.kie.sonataflow.

tiagobento · 2024-03-08T20:44:37Z

I guess @pefernan could help answer that...

pefernan · 2024-03-08T20:49:59Z

It should be org.apache.kie.sonataflow. I already sent the prs to update the groupId in all sonataflow extensions, hopefully will be merged next week.

Make sure you also use it in the extension capability! take a look at my PR's.

…uarkus Dev UI extensions

fantonangeli · 2024-03-15T15:25:21Z

Hi @paulovmr and @tiagobento , can we proceed with the reviews of this PR?

paulovmr · 2024-03-15T19:11:40Z

Hi @fantonangeli , I sent one PR to your branch earlier, I think after that is merged, this LGTM

kie-issues#1009: Remove check for data index availability on legacy Quarkus Dev UI extensions

fantonangeli · 2024-03-15T20:34:13Z

Thanks a lot @paulovmr, your PR is merged.

pefernan

@fantonangeli @paulovmr Added a few comments that, considering we'll upgrade to Quarkus 3.8, I'd fix before merging.

pefernan · 2024-03-21T22:18:00Z

...on-deployment/src/main/java/org/kie/sonataflow/swf/tools/deployment/DevConsoleProcessor.java

+public class DevConsoleProcessor {
+
+    private static final String STATIC_RESOURCES_PATH = "dev-static/";
+    private static final String BASE_RELATIVE_URL = "/q/dev-v1/org.apache.kie.sonataflow.sonataflow-quarkus-devui-extension";


Suggested change

private static final String BASE_RELATIVE_URL = "/q/dev-v1/org.apache.kie.sonataflow.sonataflow-quarkus-devui-extension";

private static final String BASE_RELATIVE_URL = "/q/dev-ui/org.apache.kie.sonataflow.sonataflow-quarkus-devui-extension";

pefernan · 2024-03-21T22:20:45Z

...on-deployment/src/main/java/org/kie/sonataflow/swf/tools/deployment/DevConsoleProcessor.java

+    private static final String BASE_RELATIVE_URL = "/q/dev-v1/org.apache.kie.sonataflow.sonataflow-quarkus-devui-extension";
+
+    @BuildStep(onlyIf = IsDevelopment.class)
+    public CardPageBuildItem pages(NonApplicationRootPathBuildItem nonApplicationRootPathBuildItem,


You may need to add the List<SystemPropertyBuildItem> as done here in order to get the data-index.url if it's not available in the configurationBuildItem

pefernan · 2024-03-21T22:22:51Z

...on-deployment/src/main/java/org/kie/sonataflow/swf/tools/deployment/DevConsoleProcessor.java

+
+    @BuildStep(onlyIf = IsDevelopment.class)
+    @Record(ExecutionTime.RUNTIME_INIT)
+    public void deployStaticResources(final DevConsoleRecorder recorder,


This DevConsoleRecorder will be removed in 3.8 LTS you may need to create one as apache/incubator-kie-kogito-apps@e7680b4#diff-ac1ccd3eb1c4080808ebca25bf08032999d51511479f4219801b1e46a1562293R32

pefernan · 2024-03-21T22:24:18Z

...sonataflow-quarkus-devui-extension-deployment/src/main/resources/dev-templates/embedded.html

+    under the License.
+
+-->
+<a href="{urlbase}/workflowInstances" class="badge badge-light">


Quarkus 3.8 completelly removes the DevUI v1, this isn't needed anymore

pefernan · 2024-03-21T22:24:29Z

...nataflow-quarkus-devui-extension-deployment/src/main/resources/dev-templates/monitoring.html

+    under the License.
+
+-->
+{#include main fluid=true} {#style} .main-container { margin: 0; padding: 0; } #envelope-app { width: 100vw; height:


Quarkus 3.8 completelly removes the DevUI v1, this isn't needed anymore

pefernan · 2024-03-21T22:24:37Z

...w-quarkus-devui-extension-deployment/src/main/resources/dev-templates/workflowInstances.html

+-->
+{#include main fluid=true} {#style} .main-container { margin: 0; padding: 0; } #envelope-app { width: 100vw; height:
+calc(100vh - 98px); } {/style} {#title}Runtime UI{/title} {#body}
+<div id="envelope-app"></div>


Quarkus 3.8 completelly removes the DevUI v1, this isn't needed anymore

paulovmr · 2024-03-22T13:25:08Z

Hi @pefernan , I'm working on those Quarkus 3.8 changes for a different PR that will go in after this is merged.

pefernan · 2024-03-22T13:27:43Z

@paulovmr in this case just forget my comments :)

paulovmr

Could you please rename the package (just the directory name and name in package.json, not the pom.xml) from sonataflow-quarkus-devui-extension-parent to sonataflow-quarkus-devui-extension?

fantonangeli · 2024-03-22T14:00:10Z

Could you please rename the package (just the directory name and name in package.json, not the pom.xml) from sonataflow-quarkus-devui-extension-parent to sonataflow-quarkus-devui-extension?

@paulovmr renamed, thank you

…tools (apache#2167) Co-authored-by: Yeser Amer <[email protected]> Co-authored-by: Thiago Lugli <[email protected]> Co-authored-by: Paulo Martins <[email protected]>

fantonangeli added 2 commits February 16, 2024 18:06

first migration of the java module

0577fb9

Resources setup

c1652ff

fantonangeli requested review from ederign, tiagobento and paulovmr as code owners February 20, 2024 17:16

fantonangeli temporarily deployed to ci February 20, 2024 17:17 — with GitHub Actions Inactive

tiagobento added area:core area:sonataflow pr: DO NOT MERGE Draft PR, not ready for merging labels Feb 20, 2024

This was referenced Feb 23, 2024

Move the BPMN Quarkus Dev UI package from kogito-apps to kie-tools apache/incubator-kie-issues#966

Closed

EPIC - Migrating Quarkus Dev UIs, Management Console, and Task Console from kogito-apps to kie-tools apache/incubator-kie-issues#967

Closed

yesamer added 17 commits February 23, 2024 18:27

Make stunner editor compatible with JDK 17

daae2bb

Test fixed

9baeac9

Test fixed

e96c6ed

Unnecessary entry

70cf51d

Removing reflection trick to mock static final fields (no longer vali…

b2468cc

…d with JDK 12+)

Update Selenium + Webdriver

b0b8993

Removing reflection trick to mock static final fields (no longer vali…

81a246c

…d with JDK 12+)

Removing reflection trick to mock static final fields (no longer vali…

3287840

…d with JDK 12+)

Removing reflection trick to mock static final fields (no longer vali…

f2ceda6

…d with JDK 12+)

Update Selenium + Webdriver

9567d6b

Updating plugin

e971dfa

Updating test dependency that doesn't support JDK 17

1b578ad

Update Selenium + Webdriver

358cddd

Removing reflection trick to mock static final fields (no longer vali…

01b50e5

…d with JDK 12+)

Removing reflection trick to mock static final fields (no longer vali…

dcca359

…d with JDK 12+)

java-vscode completion dependencies updated.

9745489

Java, Maven, Quarkus and Kogito Runtimes to 17, 3.9.6, 3.2.10 a…

5844ac4

…nd `999-20240225-SNAPSHOT`

fantonangeli temporarily deployed to ci March 8, 2024 15:33 — with GitHub Actions Inactive

fantonangeli mentioned this pull request Mar 12, 2024

kie-issues#959: Create example apps that use the Quarkus Dev UIs directly on the examples directory of kie-tools #2195

Merged

kie-issues#1009: Remove check for data index availability on legacy Q…

b692c13

…uarkus Dev UI extensions

Merge pull request #22 from paulovmr/kie-issues#1009

51d1c0c

kie-issues#1009: Remove check for data index availability on legacy Quarkus Dev UI extensions

fantonangeli temporarily deployed to ci March 15, 2024 20:33 — with GitHub Actions Inactive

paulovmr approved these changes Mar 15, 2024

View reviewed changes

paulovmr removed the pr: DO NOT MERGE Draft PR, not ready for merging label Mar 15, 2024

pefernan requested changes Mar 21, 2024

View reviewed changes

tomasdavidorg removed their assignment Mar 22, 2024

pefernan approved these changes Mar 22, 2024

View reviewed changes

paulovmr requested changes Mar 22, 2024

View reviewed changes

Fixes comment: apache#2167 (review)

40809bb

fantonangeli temporarily deployed to ci March 22, 2024 13:55 — with GitHub Actions Inactive

paulovmr approved these changes Mar 22, 2024

View reviewed changes

tiagobento merged commit 3daeaf2 into apache:main Mar 25, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KOGITO-10042: Migrate Dev UI Java module from kogito-apps to kie-tools #2167

KOGITO-10042: Migrate Dev UI Java module from kogito-apps to kie-tools #2167

fantonangeli commented Feb 20, 2024 •

edited

Loading

paulovmr commented Mar 8, 2024

tiagobento commented Mar 8, 2024

pefernan commented Mar 8, 2024

fantonangeli commented Mar 15, 2024

paulovmr commented Mar 15, 2024

fantonangeli commented Mar 15, 2024

pefernan left a comment

pefernan Mar 21, 2024

pefernan Mar 21, 2024

pefernan Mar 21, 2024

pefernan Mar 21, 2024

pefernan Mar 21, 2024

pefernan Mar 21, 2024

paulovmr commented Mar 22, 2024

pefernan commented Mar 22, 2024

paulovmr left a comment

fantonangeli commented Mar 22, 2024

	private static final String BASE_RELATIVE_URL = "/q/dev-v1/org.apache.kie.sonataflow.sonataflow-quarkus-devui-extension";
	private static final String BASE_RELATIVE_URL = "/q/dev-ui/org.apache.kie.sonataflow.sonataflow-quarkus-devui-extension";

KOGITO-10042: Migrate Dev UI Java module from kogito-apps to kie-tools #2167

KOGITO-10042: Migrate Dev UI Java module from kogito-apps to kie-tools #2167

Conversation

fantonangeli commented Feb 20, 2024 • edited Loading

paulovmr commented Mar 8, 2024

tiagobento commented Mar 8, 2024

pefernan commented Mar 8, 2024

fantonangeli commented Mar 15, 2024

paulovmr commented Mar 15, 2024

fantonangeli commented Mar 15, 2024

pefernan left a comment

Choose a reason for hiding this comment

pefernan Mar 21, 2024

Choose a reason for hiding this comment

pefernan Mar 21, 2024

Choose a reason for hiding this comment

pefernan Mar 21, 2024

Choose a reason for hiding this comment

pefernan Mar 21, 2024

Choose a reason for hiding this comment

pefernan Mar 21, 2024

Choose a reason for hiding this comment

pefernan Mar 21, 2024

Choose a reason for hiding this comment

paulovmr commented Mar 22, 2024

pefernan commented Mar 22, 2024

paulovmr left a comment

Choose a reason for hiding this comment

fantonangeli commented Mar 22, 2024

fantonangeli commented Feb 20, 2024 •

edited

Loading