kie-issues#944: On the DMN Editor, all buttons that have no displayed text should have a title. #2163
Conversation
| @@ -197,6 +199,7 @@ export function DataTypes() { | |||
| id="add-data-type-toggle" | |||
| splitButtonItems={[ | |||
| <DropdownToggleAction | |||
| {...extraPropsForDropdownToggleAction} | |||
There was a problem hiding this comment.
Added a comment...
There was a problem hiding this comment.
@tiagobento thank you for adding this improvement. It will be beneficial as for human users so for playwright testing.
I have one question about general titles we add:
- "Add"
- "Remove"
- "Close"
Would it be possible to add more detail into similar titles?
- "Add [something]"
- "Remove [something]"
- "Close [something]"
I understand it is probably not needed for human users, who understand from context, what will be "Added", "Removed" or "Closed", however if we do "page.getByTitle('Add')", it can match multiple elements and it may be difficult to write short tests then.
What is your opinion please?
|
@jomarko Yeah, I preferred to leave it as inferable from context, but I see your point. I can change it to be more specific, of course. However, I must say that we shouldn't start compromising on UI/UX in order for tests to be more easily written. I think we should of course keep tests in mind with everything that we do. IMHO we should always think what's the best UX possible for users, then figure out how to test it. |
… text should have a title. (apache#2163)
Closes apache/incubator-kie-issues#944