-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#738: Test Scenario Editor: Bee Table integration with Selector Panel #2162
Conversation
@tiagobento Ready to be reviewed and eventually merged //cc @kbowers-ibm @jomarko |
# Conflicts: # pnpm-lock.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yesamer thank you for a PR, here are my findings after doing some manual checks.
01
Expression cells can be added - I was not able to achieve this, maybe I do not know proper steps how to do it? My understanding was expression</>
is shown in header cell
02
In the DMN example, there is EXPECT column with Fine, please add new field to the Fine and compare the behavior of the search box, for Points and new PROPERTY column. In first case, it is disabled, in the second it is not.
03
insert N does not work, neither for columns, neither for rows
04
User can paste to header cells, using keyboard, but the result is unexpected probably. In the screenshots there is shown copied area and the area after pasting. For pasting the Fine header cells was selected before pressing ctrl+v
@jomarko Thank you very much for your checks.
|
@tiagobento Can I merge this after green checks, please? |
@yesamer regarding the point (4). I think the point I wanted to bring into the discussion is when selected and copied some area of data cells, with a dimension [width x height] and then user selected some header cell and pressed 'ctrl + v'. To me it seams that the header cells highlight is somehow wrong after this operation. it is the first attached screenshot in (4). |
Closes: apache/incubator-kie-issues#738
DEMO https://yesamer.github.io/prototypes/scesim-editor/
In this PR:
Screen.Recording.2024-02-16.at.16.56.37.mov