Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#738: Test Scenario Editor: Bee Table integration with Selector Panel #2162

Merged
merged 43 commits into from
Mar 27, 2024

Conversation

yesamer
Copy link
Contributor

@yesamer yesamer commented Feb 16, 2024

Closes: apache/incubator-kie-issues#738

DEMO https://yesamer.github.io/prototypes/scesim-editor/

In this PR:

  • Introduced new API to manage onClick and onKey events in the BeeTable
  • Fixed a bug in BeeTable related to InsertDirection logic
  • When selecting an EMPTY column, the selector will show all the available Data Fields (that are not already assigned in the table)
  • When selecting an assigned column, the selector points to the selected property
  • It's now possible to add a field to a selected column
  • The Creator Panel component has been moved to a separate file
  • Expression cells can be added
Screen.Recording.2024-02-16.at.16.56.37.mov

@yesamer
Copy link
Contributor Author

yesamer commented Feb 23, 2024

@tiagobento Ready to be reviewed and eventually merged

//cc @kbowers-ibm @jomarko

Copy link
Contributor

@jomarko jomarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yesamer thank you for a PR, here are my findings after doing some manual checks.

01

Expression cells can be added - I was not able to achieve this, maybe I do not know proper steps how to do it? My understanding was expression</> is shown in header cell
Screenshot 2024-03-07 081123

02

In the DMN example, there is EXPECT column with Fine, please add new field to the Fine and compare the behavior of the search box, for Points and new PROPERTY column. In first case, it is disabled, in the second it is not.
Screenshot 2024-03-07 081515
Screenshot 2024-03-07 081511

03

insert N does not work, neither for columns, neither for rows

04

User can paste to header cells, using keyboard, but the result is unexpected probably. In the screenshots there is shown copied area and the area after pasting. For pasting the Fine header cells was selected before pressing ctrl+v
Screenshot 2024-03-07 083504
Screenshot 2024-03-07 083448

@yesamer
Copy link
Contributor Author

yesamer commented Mar 14, 2024

@jomarko Thank you very much for your checks.

  1. To add an expression, select an empty column in the table and a ROOT data object in the selector data object
  2. That behavior is intended. In the first case, the user selected an empty column so it might want to add data there. In the second case, the user selected a column already populated with data, so no need to search in such a case.
  3. Not yet implemented
  4. All "copy and paste" behavior is inherited by BeeTable, no changes are applied in scesim. However, I'm not sure I've understood what's wrong here

@yesamer
Copy link
Contributor Author

yesamer commented Mar 14, 2024

@tiagobento Can I merge this after green checks, please?

@jomarko
Copy link
Contributor

jomarko commented Mar 21, 2024

@yesamer regarding the point (4). I think the point I wanted to bring into the discussion is when selected and copied some area of data cells, with a dimension [width x height] and then user selected some header cell and pressed 'ctrl + v'. To me it seams that the header cells highlight is somehow wrong after this operation. it is the first attached screenshot in (4).

@tiagobento tiagobento merged commit 8e23770 into apache:main Mar 27, 2024
8 checks passed
@yesamer yesamer deleted the kie-issues#738 branch March 27, 2024 14:59
paulovmr pushed a commit to kiegroup/kie-tools that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Scenario Editor: Bee Table integration with Selector Panel
3 participants