KOGITO-9961: Node coloring stopped working on runtime tools #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handreyrc
requested review from
ederign,
tiagobento and
paulovmr
as code owners
caponetto
added
pr: waiting-for-review
fixed export of java types to ts env
|
Hi @caponetto, @LuboTerifaj , This PR is ready for review again. BTW, Thanks @treblereel for the helping hand. |
caponetto
approved these changes
Nov 29, 2023
caponetto
added
waiting-for-qe
and removed
pr: waiting-for-review
LuboTerifaj
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Thank you for the fix @handreyrc , all tests passed and I didn't find any issues.
thiagoelg
pushed a commit
to thiagoelg/kie-tools
that referenced
this pull request
Dec 6, 2023
) Co-authored-by: Dmitrii Tikhomirov <[email protected]>
rodrigonull
pushed a commit
to rodrigonull/kie-tools
that referenced
this pull request
Dec 6, 2023
) Co-authored-by: Dmitrii Tikhomirov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @caponetto,
This fix should do the trick. Please, could you take a look.
Basically J2CL has some issues handling "JsTypes".
For now we have to use @GWT3Export along with "JsTypes" to get it working.
JIRA: KOGITO-9961
Thanks