kie-issues#577: Build a first version of the new React-based DMN Editor with ~90% feature parity with the current GWT-based one #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-able and editable.
… is in the state.
|
After a lot of testing done by me and @ljmotta, we're confident on merging this PR when the CI is green! |
ljmotta
approved these changes
Dec 22, 2023
porcelli
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
thank you for such great addition!
I understand that, due its nature, there was no option to send incremental PRs.
Thank you for all the effort behind this, DMN users will appreciate this and will be even excited to finally see the editor with the same support of the spec as the runtime!
good job!
|
@porcelli Thx! This PR is just the beginning. We have a lot of tasks to do! First we'll finish and then we'll start continuous improvements to the new DMN Editor! |
I am really loking forward to the new editor. 🙏💐 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apache/incubator-kie-issues#577
Good description coming soon...
In the mean time, some issues remain:
1. Properties panel for Boxed Expression cells on Boxed Expression Editor.Moved to apache/incubator-kie-issues#7852.processis not defined on VS Code extension while trying to import external models. To reproduce, just rundmn-vscode-extension, open a folder with some DMNs on it and click the "Included models" tab, the modal is stuck on "Loading...". There's an error on the Webview Developer Tools.3. Data Types node panel should display the complete FEEL name of external nodes Data Types. To reproduce, create a new Workspace with a Sample and a new DMN. Import the Sample on the new DMN, and add some external nodes to the default DRD. You can see that the Data Types are red and are not prefixed with the import name you chose.4. Need to add the Apache headers