Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#685: DMN Editor: Import Java Classes button is not enabled #2045

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

yesamer
Copy link
Contributor

@yesamer yesamer commented Nov 10, 2023

Closes: apache/incubator-kie-issues#685

  • In the build.properties file, the source key was incidentally changed here to ource. That was the reason for the issue
  • Removed any reference to the old Annotation previously mandatory to enable the feature.
  • Updated JDT.LS to 1.29
  • Updated freemarker
  • Removed generated Java Autocompletion jar in BPMN Editor: not used here, it doesn't make sense to add it.

@yesamer yesamer changed the title kie issues#685 kie issues#685: DMN Editor: Import Java Classes button is not enabled Nov 10, 2023
@yesamer
Copy link
Contributor Author

yesamer commented Nov 11, 2023

@tiagobento @Josephblt I don't understand why is failing here:

.../kie-sandbox-extended-services-image build:dev: cp: cannot stat '../extended-services-java/dist/extended-services-java': No such file or directory

It fails in my local too. Can you please doublecheck?

@Josephblt
Copy link
Member

Hello @yesamer. I'm not home today. I'll check it tomorrow. As soon as I have something I'll get back to you.

@Josephblt
Copy link
Member

Hello @yesamer. Here is the fix for the failing builds in your PR.
https://github.com/kiegroup/kie-tools/pull/2050
As soon as it gets merged, I'll let you know and you can rerun the builds.

@yesamer
Copy link
Contributor Author

yesamer commented Nov 14, 2023

Hello @yesamer. Here is the fix for the failing builds in your PR. #2050 As soon as it gets merged, I'll let you know and you can rerun the builds.

Thank you @Josephblt

@yesamer yesamer merged commit 8bc7e3f into apache:main Nov 14, 2023
8 checks passed
@yesamer yesamer deleted the #kie-issues#685 branch November 14, 2023 10:24
@yesamer yesamer changed the title kie issues#685: DMN Editor: Import Java Classes button is not enabled kie-issues#685: DMN Editor: Import Java Classes button is not enabled Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMN Editor: Import Java Classes button is not enabled
3 participants