NO-ISSUE: start script on extended-services-java should not require Docker
#2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josephblt
requested review from
ederign,
tiagobento and
paulovmr
as code owners
tiagobento
changed the title
start script on extended-services-java should not require Docker
tiagobento
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extended-services-java app requires docker to be installed when executing in dev mode (pnpm start).
This is because by default dev services are enabled when executing in dev mode. This fix disables it, so docker is not required anymore.
There are also minor changes to some READ-ME files and some environment variable descriptions.