KOGITO-8949: Recreate TrySample test for Serverless Logic Web Tools #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasdavidorg
requested review from
ederign,
tiagobento and
paulovmr
as code owners
tomasdavidorg
added
waiting-for-qe
pr: waiting-for-review
tomasdavidorg
force-pushed
the
KOGITO-8949
branch
from
07cbee2 to
29e0cc5
Compare
paulovmr
approved these changes
Nov 7, 2023
tomasdavidorg
force-pushed
the
KOGITO-8949
branch
from
29e0cc5 to
2908ccd
Compare
tomasdavidorg
force-pushed
the
KOGITO-8949
branch
from
2908ccd to
5cba240
Compare
|
Rebased with main branch because of the Cypress update. |
LuboTerifaj
approved these changes
Nov 22, 2023
|
@tomasdavidorg Could you please resolve the conflict so I can merge this PR? |
Signed-off-by: Tomas David <[email protected]>
tomasdavidorg
force-pushed
the
KOGITO-8949
branch
from
5cba240 to
b3eb504
Compare
|
@caponetto Rebased and the checks are green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/KOGITO-8949
This PR recreates the e2e test for trying samples from the catalog.
The catalog downloads the samples from GitHub repository which causes that the API limit is exceeded and the samples are not loaded.
In this PR, the test expects GitHub token as
CYPRESS_E2E_TEST_GITHUB_TOKENenv. variable and run the tests only if the token is present.GitHub action will not run the tests because currently there is no test token. It is primary focused on QE Jenkins runs but if needed we can add the token to the GitHub actions credentials.