kie-issue#206: Enable autocomplete suggestions for Literal Expressions and Decision Table input cells on DMN Editor's Boxed Expression Editor #2018
Conversation
danielzhe
requested review from
ederign,
tiagobento and
paulovmr
as code owners
There was a problem hiding this comment.
Thank you for this cool feature @danielzhe . I found some interesting scenario when monaco starts to offer fields of nested structures, I think it offered me inappropriate options on the second level. See :
and try to model same decision in:
types.dmn.txt
Also, am I correct imported models are not partof this PR, right? apache/incubator-kie-issues#539
|
Thank you, @jomarko ! About the included models, they are not part of this PR yet. It's gonna take a few more time to make that feature available because we have to "parse" all the imported nodes and we don't want to load all models using the old Marshaller in GWT side because of performance reasons and it can lead to a lot of wasted work as soon as we finish the migration to a full non-GWT editor. @tiagobento is working on that. |
…ressions and Decision Table input cells on DMN Editor's Boxed Expression Editor
danielzhe
force-pushed
the
feel-autocomplete
branch
from
488a695 to
c36cbe7
Compare
|
@danielzhe There is a way to disable these suggestions from Monaco. I did it for SWF, but I don't remember how :D |
|
@tiagobento Fixed the issue about recursive calls that we talked in pvt. |
|
@jomarko @tiagobento Changes applied, ready for your review. I also did an improvement to allow space to trigger the autocomplete suggestions. |
| @@ -83,6 +83,7 @@ export const feelDefaultConfig = ( | |||
| minimap: { | |||
| enabled: false, | |||
| }, | |||
| wordBasedSuggestions: false, | |||
There was a problem hiding this comment.
LGTM, thank you @danielzhe for this amazing feature.
Please consider implementing a Test Suite for this new feature.
There was a problem hiding this comment.
I can confirm, in situation described originally as https://github.com/kiegroup/kie-tools/pull/2018#pullrequestreview-1689835344 are not these 'wrong' autosuggestions present anymore.
In the same scenario, currently no suggestions are present, what is probably expected? At least that is my feelingreading comments from @danielzhe and @tiagobento
Thank you for the PR!
Closes: apache/incubator-kie-issues#206
Enables autocomplete for FEEL expressions.
Screen.Recording.2023-10-18.at.15.52.29.mov