Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Remove deleted packages on the lock file #2009

Merged
merged 1 commit into from
Oct 9, 2023
Merged

NO-ISSUE: Remove deleted packages on the lock file #2009

merged 1 commit into from
Oct 9, 2023

Conversation

caponetto
Copy link
Contributor

No description provided.

@caponetto caponetto temporarily deployed to ci October 6, 2023 17:05 — with GitHub Actions Inactive
@caponetto caponetto temporarily deployed to ci October 6, 2023 17:05 — with GitHub Actions Inactive
@caponetto caponetto temporarily deployed to ci October 6, 2023 17:06 — with GitHub Actions Inactive
@tiagobento
Copy link
Contributor

@caponetto Do we have any idea was causes this? I observed that sometimes it occurs on my local... But I'm really not sure what I might be doing wrong.

@caponetto
Copy link
Contributor Author

@tiagobento I think something is up here.
Especially with -F !kie-tools-root... ${pnpmFilterStringForInstalling}.

If you delete a package from the workspace and run pnpm bootstrap, the lock file is kept untouched.
On the other hand, if you remove -F !kie-tools-root... ${pnpmFilterStringForInstalling} to test and run pnpm bootstrap, the deleted package is also removed from the lock file.

I will take a better look at it next week but any ideas are welcome.
Maybe something changed after the upgrade to v8?

@caponetto caponetto merged commit ab01053 into apache:main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants