-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Do not run e2e tests on build image steps in the staging job #2004
Conversation
I think they may be useful in some cases, like when the latest PR(s) only ran a partial build, then they might identify an issue. |
@paulovmr If a PR only ran a partial build, it's 100% guaranteed that the full build is green. We don't run partial builds when there's a chance that we'll break something else that we're not building on the partial build. |
@caponetto My mistake, for the image builds I agree that those tests are not necessary. My argument would be more for the "full" build without some images, but I guess I was thinking of a case where the problem was two merges in a row, not the partial build failing to catch a problem. So forget that. :) |
No description provided.