Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Do not run e2e tests on build image steps in the staging job #2004

Merged
merged 2 commits into from
Oct 6, 2023
Merged

NO-ISSUE: Do not run e2e tests on build image steps in the staging job #2004

merged 2 commits into from
Oct 6, 2023

Conversation

caponetto
Copy link
Contributor

No description provided.

@caponetto caponetto temporarily deployed to ci October 5, 2023 18:56 — with GitHub Actions Inactive
@caponetto caponetto temporarily deployed to ci October 5, 2023 18:57 — with GitHub Actions Inactive
@caponetto caponetto temporarily deployed to ci October 5, 2023 18:57 — with GitHub Actions Inactive
@paulovmr paulovmr changed the title [NO-ISSUE] Rename integration test env var leftovers NO-ISSUE: Rename integration test env var leftovers Oct 5, 2023
@caponetto caponetto added the pr: waiting-for-ci CI is still running or broken. label Oct 5, 2023
@caponetto
Copy link
Contributor Author

On second thought, I think we don't need e2e tests enabled in those places. wdyt @paulovmr @ljmotta?

@paulovmr
Copy link
Member

paulovmr commented Oct 5, 2023

I think they may be useful in some cases, like when the latest PR(s) only ran a partial build, then they might identify an issue.

@tiagobento
Copy link
Contributor

@paulovmr If a PR only ran a partial build, it's 100% guaranteed that the full build is green. We don't run partial builds when there's a chance that we'll break something else that we're not building on the partial build.

@paulovmr
Copy link
Member

paulovmr commented Oct 5, 2023

@caponetto My mistake, for the image builds I agree that those tests are not necessary.

My argument would be more for the "full" build without some images, but I guess I was thinking of a case where the problem was two merges in a row, not the partial build failing to catch a problem. So forget that. :)

@caponetto caponetto temporarily deployed to ci October 6, 2023 09:28 — with GitHub Actions Inactive
@caponetto caponetto temporarily deployed to ci October 6, 2023 09:28 — with GitHub Actions Inactive
@caponetto caponetto temporarily deployed to ci October 6, 2023 09:28 — with GitHub Actions Inactive
@caponetto caponetto requested review from paulovmr and ljmotta October 6, 2023 09:28
@caponetto caponetto changed the title NO-ISSUE: Rename integration test env var leftovers NO-ISSUE: Do not run e2e tests on build image steps in the staging job Oct 6, 2023
@tiagobento tiagobento merged commit d3a17b7 into apache:main Oct 6, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core pr: waiting-for-ci CI is still running or broken.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants