Revert "NO-ISSUE: Update go to 1.21.1 follow-up (#1966)"

[dsimansk]

This reverts commit 219907d.

Per my comment on: https://issues.redhat.com/browse/KOGITO-9799.

We should treat Go toolchain and go.mod min version as two separate entities. Because the latest Golang might not be available in the internal build systems etc.

[zdrapela]

Thanks for the fix. I wasn't aware of that.

It looks good. Just so you know, check on this PR misses the IT/E2E tests in kn-plugin-workflow and doesn't run them. This will be fixed in PR #1992 (which depends on PR #1998 being merged first). It might be good to merge those first just to make sure.

[dsimansk]

Thanks for the fix. I wasn't aware of that.

It looks good. Just so you know, check on this PR misses the IT/E2E tests in kn-plugin-workflow and doesn't run them. This will be fixed in PR #1992 (which depends on PR #1998 being merged first). It might be good to merge those first just to make sure.

No worries, it's always a bit tricky with Go versions. I can share a few stories that have bitten us so far.

Anyway for the merge order, your proposal sounds good. But please note that there's a bit of time pressure to pull kn-plugin-workflow into kn for the next product build cycle. Depending really how much time the other 2 PRs will take.

[tiagobento]

Was discussing this with @ljmotta and our understanding is that this PR makes it possible to continue building kie-tools with any Go version higher than or equal to 1.20, is that correct?

[dsimansk]

Was discussing this with @ljmotta and our understanding is that this PR makes it possible to continue building kie-tools with any Go version higher than or equal to 1.20, is that correct?

Yes, that's correct. That's the exact motivation for the PR. For that reason it isn't changing any Go version configured in GitHub action.

https://go.dev/doc/modules/gomod-ref#go

[dsimansk]

@caponetto @zdrapela I've rebased the PR. Kindly asking for GH actions run approval, pls. :)