-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#172: Write integration tests for DMN Editor's Boxed Expression Editor using PlayWright and Storybook #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagobento
approved these changes
Sep 28, 2023
ljmotta
force-pushed
the
kie-issues-172
branch
from
September 28, 2023 14:02
a81dbba
to
3547092
Compare
paulovmr
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
Closes apache/incubator-kie-issues#172
On this PR
It bootstraps a new test strategy for the kie-tools monorepo as part of the apache/incubator-kie-issues#457 EPIC. This PR replaces the
integration
withend-to-end
, adds the Playwright framework, adds the Storybook as a testing target platform and documentation tool.End-to-end tests
To create the new tests for the
boxed-expression-component
, the combination of two tools. Playwright is an end-to-end (E2E) testing framework, which has the capabilities to run tests in parallel, WebKit support, and iframe support. Storybook provides a clean environment as a target for the tests, and a documentation tool. This documentation can be published like the following: https://ljmotta.github.io/kie-tools-demos/?path=/story/dev-web-app--web-appnew packages
It adds two new packages
playwright-base
Adds the default configuration file for the Playwright framework. This configuration file should be used for any other package that wants to use the Playwright framework for the E2E tests.
storybook-base
Adds the default configuration file for the Storybook tool. This configuration file should be used for any other package that wants to use the Storybook tool.
Affected packages
boxed-expression-component
Adds E2E tests and storybook.
chrome-extension-pack-kogito-kie-editors
Replaced
integration
withend-to-end
. Replacedit
withe2e
. ReplacedintegrationTests
env variable withendToEndTests
. Moved tests fromit-tests
toe2e-tests
folder. Samples were left in theit-tests
folder as it has a dependency on the kie-toolsmain
branch (Change the E2E test strategy for the chrome-extension packages as they point to specific files onkie-tools
and other repos incubator-kie-issues#554).chrome-extension-serverless-workflow-editor
Replaced
integration
withend-to-end
. Replacedit
withe2e
. ReplacedintegrationTests
env variable withendToEndTests
. Moved tests fromit-tests
toe2e-tests
folder. Samples were left in theit-tests
folder as it has a dependency on the kie-toolsmain
branch (Change the E2E test strategy for the chrome-extension packages as they point to specific files onkie-tools
and other repos incubator-kie-issues#554).chrome-extension-test-helper
Replace
it
withe2e
.feel-input-component
Add data-testid to the Monaco editor container
kie-editors-dev-vscode-extension
Replaced
integration
withend-to-end
. Replacedit
withe2e
. ReplacedintegrationTests
env variable withendToEndTests
. Moved tests fromit-tests
toe2e-tests
folder.kie-editors-standalone
Replaced
integration
withend-to-end
. Replacedit
withe2e
. ReplacedintegrationTests
env variable withendToEndTests
. Moved tests fromit-tests
toe2e-tests
folder.kn-plugin-workflow
Replaced
integration
withend-to-end
. Replacedit
withe2e
. ReplacedintegrationTests
env variable withendToEndTests
. Moved tests fromit-tests
toe2e-tests
folder.online-editor
Replaced
integration
withend-to-end
. Replacedit
withe2e
. ReplacedintegrationTests
env variable withendToEndTests
. Moved tests fromit-tests
toe2e-tests
folder. Created new tests and removed tests.pmml-editor
Replaced
integration
withend-to-end
. Replacedit
withe2e
. ReplacedintegrationTests
env variable withendToEndTests
. Moved tests fromit-tests
toe2e-tests
folder.root-env/env
Replaced
integration
withend-to-end
. Replacedit
withe2e
. ReplacedintegrationTests
env variable withendToEndTests
. Moved tests fromit-tests
toe2e-tests
folder.scesim-editor
Replaced
it
withe2e
.serverless-logic-web-tools
Replaced
integration
withend-to-end
. Replacedit
withe2e
. ReplacedintegrationTests
env variable withendToEndTests
. Moved tests fromit-tests
toe2e-tests
folder.serverless-workflow-diagram-editor
Replaced
integrationTests
env variable withendToEndTests
.serverless-workflow-vscode-extension
Replaced
integration
withend-to-end
. Replacedit
withe2e
. ReplacedintegrationTests
env variable withendToEndTests
. Moved tests fromit-tests
toe2e-tests
folder.stunner-editors
Replaced
integration
withend-to-end
. ReplacedintegrationTests
env variable withendToEndTests
.vscode-extension-dashbuilder-editor
Replaced
integration
withend-to-end
. Replacedit
withe2e
. ReplacedintegrationTests
env variable withendToEndTests
. Moved tests fromit-tests
toe2e-tests
folder.yard-vscode-extension
Replaced
integration
withend-to-end
. Replacedit
withe2e
. ReplacedintegrationTests
env variable withendToEndTests
. Moved tests fromit-tests
toe2e-tests
folder.