KOGITO-9195: YaRD editor validation #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Temp commit to show progress. The code can now find subsumption that is the basic function for redundancy and conflict resolution. Needs more test data to be really really done, I will be adding that next. |
|
Missing items needed for commit:
|
|
Transpiling LocalDateTime correctly is more challenging than expected, but on it. |
|
@paulovmr I could use some help on figuring out the formatting for the README and yml file. Can I run a formatter for them locally? Other than that I could also use a code review for the code. |
caponetto
reviewed
Oct 20, 2023
|
Yes the PR makes sense, I merged it in. |
|
Looks like I still lack the right files for formatting the pom.xml files. |
parser KOGITO-9197 : YaRD editor: Use old dtable validation codes for subsumption KOGITO-9517 : YaRD editor: Use J2CL to generate a JS module Suggestions (cherry picked from commit 751bb8f)
|
Figured it out. |
paulovmr
approved these changes
Nov 21, 2023
caponetto
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets this change has:
YaRD editor: Create yard-validation project with model parser
YaRD editor: Use old dtable validation codes for subsumption
YaRD editor: Use J2CL to generate a JS module
I split the model to a separate project, but since this validation is the only module that will use it, I will investigate if the two modules should be merged together.