Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KOGITO-7740: KN Workflow plugin does not allow to use RHBQ version #1175

Merged
merged 4 commits into from
Aug 11, 2022

Conversation

ljmotta
Copy link
Contributor

@ljmotta ljmotta commented Aug 10, 2022

JIRA

https://issues.redhat.com/browse/KOGITO-7740

On this PR

  • Add [--quarkus-platform-group-id|-G] to change the the Quarkus platform group Id.
  • Add a P flag for --quarkus-version. Now, the Quarkus version can be also changed with the -V flag.
  • Remove the --kogito-version flag, as it should be determined by the quarkus-kogito-bom.
  • Remove the config subcommand as it should manipulate the bom version instead of extension versions.

@ljmotta ljmotta changed the title KOGITO-7740 KOGITO-7740: KN Workflow plugin does not allow to use RHBQ version Aug 10, 2022
@jstastny-cz
Copy link
Contributor

Does any of the checks produce the plugin binary to test or should I checkout the branch?

@caponetto
Copy link
Contributor

caponetto commented Aug 11, 2022

@jstastny-cz The artifacts associated with this PR are available in the last CI :: Monorepo run of this PR [1].

[1] https://github.com/kiegroup/kie-tools/actions/runs/2836163777

@cimbalek
Copy link
Contributor

cimbalek commented Aug 11, 2022

@ljmotta Hi, do we track changes in documentation related to this PR anywhere, please?

@jstastny-cz
Copy link
Contributor

I've been able to run successfully command as
kn workflow create --name serverless-workflow-hello-world --extension quarkus-jsonp,quarkus-smallrye-openapi -G com.redhat.quarkus.platform -V 2.7.6.Final-redhat-00006
Looking at the output, there seems to be some unintended fragment popping up in console:

✅ Checking dependencies...
 - Java version check.
 - Maven version check.
-DplatformVersion=2.7.6.Final-redhat-00006Creating a Kogito Serverless Workflow project...
Workflow file created on ./serverless-workflow-hello-world/src/main/resources/workflow.sw.json 
🚀 Project creation took: 6.075902689s 

specifically -DplatformVersion=2.7.6.Final-redhat-00006 3rd line from the bottom.

@ljmotta
Copy link
Contributor Author

ljmotta commented Aug 11, 2022

@cimbalek These changes will be added in the https://github.com/kiegroup/kogito-docs/pull/135

@jstastny-cz Thanks for testing. Indeed I forgot a log there while I was testing. Could you please re-test? Also, regarding the https://issues.redhat.com/browse/KOGITO-7742, with those fixes, the default bom (quarkus-kogito-bom) should be generated.

Edit:
You can download the updated version here https://github.com/kiegroup/kie-tools/actions/runs/2839520279

Copy link
Contributor

@jstastny-cz jstastny-cz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@paulovmr paulovmr merged commit f0cbfc4 into apache:main Aug 11, 2022
ricardozanini pushed a commit to ricardozanini/kogito-tooling that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants